Use a macro for form tags

This will stop us repeatedly forgetting to add `novalidate` and
`autocomplete='off'` to our forms (which is how most of them are set
up).

It uses sensible defaults, based on how we most-commonly configure
forms:
- most of our forms are `post`ed (but this can be overridden)
- `autocomplete` should only be enabled where it makes sense, otherwise
  it’s more annoying than useful (but this can be overriden)
- we should never be using HTML5 form validation because our own error
  styles and messages are better
This commit is contained in:
Chris Hill-Scott
2018-09-19 12:39:36 +01:00
parent 5ab876aeab
commit d9da219b7e
72 changed files with 257 additions and 170 deletions

View File

@@ -2,6 +2,7 @@
{% from "components/textbox.html" import textbox %}
{% from "components/checkbox.html" import checkbox %}
{% from "components/page-footer.html" import page_footer %}
{% from "components/form.html" import form_wrapper %}
{% block per_page_title %}
Text verification
@@ -15,7 +16,7 @@
<p>Weve sent you a text message with a security code.</p>
<form autocomplete="off" method="post" class="extra-tracking" novalidate>
{% call form_wrapper(class="extra-tracking") %}
{{ textbox(
form.sms_code,
width='5em',
@@ -26,7 +27,7 @@
secondary_link=url_for('main.check_and_resend_text_code'),
secondary_link_text='Not received a text message?'
) }}
</form>
{% endcall %}
</div>
</div>