darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-09-08 23:33:12 -04:00
Code Issues Packages Projects Releases Wiki Activity

Add screen reader suffixes on all org settings

Browse Source 
So screen reader users have consistent experience.
This commit is contained in:
Pea Tyczynska
2021-02-10 15:49:49 +00:00
parent 741beeb903
commit d7596f81fb
2 changed files with 39 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

38
app/templates/views/organisations/organisation/settings/index.html
View File

@@ -19,7 +19,8 @@
{{ text_field(current_org.name) }} {{ text_field(current_org.name) }}
{{ edit_field( {{ edit_field(
'Change', 'Change',
url_for('.edit_organisation_name', org_id=current_org.id) url_for('.edit_organisation_name', org_id=current_org.id),
suffix='organisation name'
) )
}} }}
{% endcall %} {% endcall %}
@@ -28,7 +29,8 @@
{{ optional_text_field(current_org.organisation_type_label) }} {{ optional_text_field(current_org.organisation_type_label) }}
{{ edit_field( {{ edit_field(
'Change', 'Change',
url_for('.edit_organisation_type', org_id=current_org.id) url_for('.edit_organisation_type', org_id=current_org.id),
suffix='sector for the organisation'
) )
}} }}
{% endcall %} {% endcall %}
@@ -43,7 +45,8 @@
) }} ) }}
{{ edit_field( {{ edit_field(
'Change', 'Change',
url_for('.edit_organisation_crown_status', org_id=current_org.id) url_for('.edit_organisation_crown_status', org_id=current_org.id),
suffix='organisation crown status'
) )
}} }}
{% endcall %} {% endcall %}
@@ -58,7 +61,8 @@
) }} ) }}
{{ edit_field( {{ edit_field(
'Change', 'Change',
url_for('.edit_organisation_agreement', org_id=current_org.id) url_for('.edit_organisation_agreement', org_id=current_org.id),
suffix='data sharing and financial agreement for the organisation'
) )
}} }}
{% endcall %} {% endcall %}
@@ -67,7 +71,8 @@
{{ optional_text_field(current_org.request_to_go_live_notes, default='None') }} {{ optional_text_field(current_org.request_to_go_live_notes, default='None') }}
{{ edit_field( {{ edit_field(
'Change', 'Change',
url_for('.edit_organisation_go_live_notes', org_id=current_org.id) url_for('.edit_organisation_go_live_notes', org_id=current_org.id),
suffix='go live notes for the organisation'
) )
}} }}
{% endcall %} {% endcall %}
@@ -75,13 +80,23 @@
{% call row() %} {% call row() %}
{{ text_field('Billing details')}} {{ text_field('Billing details')}}
{{ optional_text_field(current_org.billing_details, default="No billing details yet", wrap=True) }} {{ optional_text_field(current_org.billing_details, default="No billing details yet", wrap=True) }}
{{ edit_field('Change', url_for('.edit_organisation_billing_details', org_id=current_org.id), suffix='billing details for the organisation') }} {{ edit_field(
'Change',
url_for('.edit_organisation_billing_details', org_id=current_org.id),
suffix='billing details for the organisation'
)
}}
{% endcall %} {% endcall %}
{% call row() %} {% call row() %}
{{ text_field('Notes')}} {{ text_field('Notes')}}
{{ optional_text_field(current_org.notes, default="No notes yet", wrap=True) }} {{ optional_text_field(current_org.notes, default="No notes yet", wrap=True) }}
{{ edit_field('Change', url_for('.edit_organisation_notes', org_id=current_org.id), suffix='the notes for the organisation') }} {{ edit_field(
'Change',
url_for('.edit_organisation_notes', org_id=current_org.id),
suffix='the notes for the organisation'
)
}}
{% endcall %} {% endcall %}
{% call row() %} {% call row() %}
@@ -89,7 +104,8 @@
{{ text_field(current_org.email_branding_name) }} {{ text_field(current_org.email_branding_name) }}
{{ edit_field( {{ edit_field(
'Change', 'Change',
url_for('.edit_organisation_email_branding', org_id=current_org.id) url_for('.edit_organisation_email_branding', org_id=current_org.id),
suffix='default email branding for the organisation'
) )
}} }}
{% endcall %} {% endcall %}
@@ -101,7 +117,8 @@
) }} ) }}
{{ edit_field( {{ edit_field(
'Change', 'Change',
url_for('.edit_organisation_letter_branding', org_id=current_org.id) url_for('.edit_organisation_letter_branding', org_id=current_org.id),
suffix='default letter branding for the organisation'
) )
}} }}
{% endcall %} {% endcall %}
@@ -110,7 +127,8 @@
{{ optional_text_field(current_org.domains or None, default='None') }} {{ optional_text_field(current_org.domains or None, default='None') }}
{{ edit_field( {{ edit_field(
'Change', 'Change',
url_for('.edit_organisation_domains', org_id=current_org.id) url_for('.edit_organisation_domains', org_id=current_org.id),
suffix='known email domains for the organisation'
) )
}} }}
{% endcall %} {% endcall %}

19
tests/app/main/views/organisations/test_organisations.py
View File

@@ -686,16 +686,19 @@ def test_organisation_settings_for_platform_admin(
): ):
expected_rows = [ expected_rows = [
'Label Value Action', 'Label Value Action',
'Name Test organisation Change', 'Name Test organisation Change organisation name',
'Sector Central government Change', 'Sector Central government Change sector for the organisation',
'Crown organisation Yes Change', 'Crown organisation Yes Change organisation crown status',
'Data sharing and financial agreement Not signed Change', (
'Request to go live notes None Change', 'Data sharing and financial agreement '
'Not signed Change data sharing and financial agreement for the organisation'
),
'Request to go live notes None Change go live notes for the organisation',
'Billing details No billing details yet Change billing details for the organisation', 'Billing details No billing details yet Change billing details for the organisation',
'Notes No notes yet Change the notes for the organisation', 'Notes No notes yet Change the notes for the organisation',
'Default email branding GOV.UK Change', 'Default email branding GOV.UK Change default email branding for the organisation',
'Default letter branding No branding Change', 'Default letter branding No branding Change default letter branding for the organisation',
'Known email domains None Change', 'Known email domains None Change known email domains for the organisation',
] ]
client_request.login(platform_admin_user) client_request.login(platform_admin_user)