darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-08-26 17:24:23 -04:00
Code Issues Packages Projects Releases Wiki Activity

Rename cell broadcasts

Browse Source 
‘Emergency alerts’ is the confirmed name of the service now.
This commit is contained in:
Chris Hill-Scott
2021-05-11 11:14:32 +01:00
parent a0f54539cc
commit d720b0e47a
2 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
app/templates/views/service-settings.html
View File

@@ -429,7 +429,7 @@
{% endfor %} {% endfor %}
{% call row() %} {% call row() %}
{{ text_field('Send cell broadcasts')}} {{ text_field('Emergency alerts')}}
{% call field(wrap=True) %} {% call field(wrap=True) %}
{% if not current_service.broadcast_channel %} {% if not current_service.broadcast_channel %}
Off Off
@@ -443,7 +443,7 @@
{{ edit_field( {{ edit_field(
'Change', 'Change',
url_for('.service_set_broadcast_channel', service_id=current_service.id), url_for('.service_set_broadcast_channel', service_id=current_service.id),
suffix='your settings for Send cell broadcasts' suffix='your settings for emergency alerts'
) )
}} }}
{% endcall %} {% endcall %}

6
tests/app/main/views/test_service_settings.py
View File

@@ -113,7 +113,7 @@ def mock_get_service_settings_page_common(
'Custom data retention Email – 7 days Change data retention', 'Custom data retention Email – 7 days Change data retention',
'Receive inbound SMS Off Change your settings for Receive inbound SMS', 'Receive inbound SMS Off Change your settings for Receive inbound SMS',
'Email authentication Off Change your settings for Email authentication', 'Email authentication Off Change your settings for Email authentication',
'Send cell broadcasts Off Change your settings for Send cell broadcasts', 'Emergency alerts Off Change your settings for emergency alerts',
]), ]),
]) ])
def test_should_show_overview( def test_should_show_overview(
@@ -186,7 +186,7 @@ def test_platform_admin_sees_only_relevant_settings_for_broadcast_service(
'Label Value Action', 'Label Value Action',
'Notes None Change the notes for the service', 'Notes None Change the notes for the service',
'Email authentication Off Change your settings for Email authentication', 'Email authentication Off Change your settings for Email authentication',
'Send cell broadcasts Training Change your settings for Send cell broadcasts', 'Emergency alerts Training Change your settings for emergency alerts',
] ]
assert len(rows) == len(expected_rows) assert len(rows) == len(expected_rows)
@@ -238,7 +238,7 @@ def test_platform_admin_sees_correct_description_of_broadcast_service_setting(
)) ))
assert response.status_code == 200 assert response.status_code == 200
page = BeautifulSoup(response.data.decode('utf-8'), 'html.parser') page = BeautifulSoup(response.data.decode('utf-8'), 'html.parser')
broadcast_setting_row = page.find(string=re.compile("Send cell broadcasts")).find_parent('tr') broadcast_setting_row = page.find(string=re.compile("Emergency alerts")).find_parent('tr')
broadcast_setting_description = broadcast_setting_row.select('td')[1].text.strip() broadcast_setting_description = broadcast_setting_row.select('td')[1].text.strip()
assert broadcast_setting_description == expected_text assert broadcast_setting_description == expected_text