darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-09-07 21:38:26 -04:00
Code Issues Packages Projects Releases Wiki Activity

Remove hack for bug in Chrome autocomplete

Browse Source 
We added an extra, hidden, <input> to our /sign-in
and /register forms to stop Chrome's form
heuristics filling the fields in wrong.

See the commit that added it:

33b15cdec6

This removes it after testing with the following
Chrome/OS combinations and all working without the
hack:

- Chrome 87, Windows 7
- Chrome 86, Windows 7
- Chrome 86, Windows 10
- Chrome 85, Windows 7
- Chrome 80, Windows 10
- Chrome 81, Windows 7
- Chrome 52, Windows 7
- Chrome 68, Windows 7
- Chrome 78, Windows 8.1
- Chrome 86, Windows 8.1

These combinations were based on the most-used
versions recorded in our analytics for the last 3
months.
This commit is contained in:
Tom Byers
2021-01-05 17:08:50 +00:00
parent ad44e10cb7
commit d6ffcd3abe
1 changed files with 0 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
app/templates/views/register.html
View File

@@ -27,7 +27,6 @@ Create an account
"classes": "govuk-!-width-three-quarters" "classes": "govuk-!-width-three-quarters"
}) }} }) }}
</div> </div>
<input class="govuk-visually-hidden" aria-hidden="true" tabindex="-1" id="defeat-chrome-autocomplete">
{{ form.password(param_extensions={"hint": {"text": "At least 8 characters"}, "classes": "govuk-!-width-three-quarters", "autocomplete": "new-password"}) }} {{ form.password(param_extensions={"hint": {"text": "At least 8 characters"}, "classes": "govuk-!-width-three-quarters", "autocomplete": "new-password"}) }}
{{form.auth_type}} {{form.auth_type}}
{{ page_footer("Continue") }} {{ page_footer("Continue") }}