From d65be41da5804a5e4ea76ee87e0788b64104e71d Mon Sep 17 00:00:00 2001 From: Beverly Nguyen Date: Tue, 29 Jul 2025 10:17:35 -0700 Subject: [PATCH] fix test get_immediate_jobs for download availability check --- tests/app/main/views/test_jobs_activity.py | 26 ++++++++++++++++++---- 1 file changed, 22 insertions(+), 4 deletions(-) diff --git a/tests/app/main/views/test_jobs_activity.py b/tests/app/main/views/test_jobs_activity.py index 125b8e46a..ff1e7080d 100644 --- a/tests/app/main/views/test_jobs_activity.py +++ b/tests/app/main/views/test_jobs_activity.py @@ -50,6 +50,9 @@ def test_all_activity( mock_get_page_of_jobs = mocker.patch( "app.job_api_client.get_page_of_jobs", return_value=MOCK_JOBS ) + mocker.patch( + "app.job_api_client.get_immediate_jobs", return_value=[] + ) response = client_request.get_response( "main.all_jobs_activity", @@ -60,7 +63,11 @@ def test_all_activity( assert response.data is not None, "Response data is None" assert "All activity" in response.text - mock_get_page_of_jobs.assert_called_with(SERVICE_ONE_ID, page=current_page) + + assert any( + call[0][0] == SERVICE_ONE_ID and call[1].get('page') == current_page + for call in mock_get_page_of_jobs.call_args_list + ) page = BeautifulSoup(response.data, "html.parser") table = page.find("table") assert table is not None, "Table not found in the response" @@ -115,7 +122,6 @@ def test_all_activity( failed_cell = cells[6].get_text(strip=True) assert failed_cell == "5", f"Expected failed count '5', but got '{failed_cell}'" - mock_get_page_of_jobs.assert_called_with(SERVICE_ONE_ID, page=current_page) def test_all_activity_no_jobs(client_request, mocker): @@ -133,6 +139,9 @@ def test_all_activity_no_jobs(client_request, mocker): "total": 0, }, ) + mocker.patch( + "app.job_api_client.get_immediate_jobs", return_value=[] + ) response = client_request.get_response( "main.all_jobs_activity", service_id=SERVICE_ONE_ID, @@ -152,7 +161,10 @@ def test_all_activity_no_jobs(client_request, mocker): assert ( expected_message == actual_message ), f"Expected message '{expected_message}', but got '{actual_message}'" - mock_get_page_of_jobs.assert_called_with(SERVICE_ONE_ID, page=current_page) + assert any( + call[0][0] == SERVICE_ONE_ID and call[1].get('page') == current_page + for call in mock_get_page_of_jobs.call_args_list + ) def test_all_activity_pagination(client_request, mocker): @@ -182,13 +194,19 @@ def test_all_activity_pagination(client_request, mocker): "total": 100, }, ) + mocker.patch( + "app.job_api_client.get_immediate_jobs", return_value=[] + ) response = client_request.get_response( "main.all_jobs_activity", service_id=SERVICE_ONE_ID, page=current_page, ) - mock_get_page_of_jobs.assert_called_with(SERVICE_ONE_ID, page=current_page) + assert any( + call[0][0] == SERVICE_ONE_ID and call[1].get('page') == current_page + for call in mock_get_page_of_jobs.call_args_list + ) page = BeautifulSoup(response.data, "html.parser") pagination_controls = page.find_all("li", class_="usa-pagination__item")