don't allow bad filetypes to preview

This commit is contained in:
Leo Hemsted
2017-04-12 12:12:11 +01:00
parent a0470b40ea
commit d655a38e14
4 changed files with 43 additions and 0 deletions

View File

@@ -577,6 +577,25 @@ def test_should_show_preview_letter_message(
assert mocked_preview.call_args[0][1] == filetype
def test_dont_show_preview_letter_templates_for_bad_filetype(
logged_in_client,
mock_get_service_template,
service_one,
fake_uuid
):
resp = logged_in_client.get(
url_for(
'main.check_messages_preview',
service_id=service_one['id'],
template_type='letter',
upload_id=fake_uuid,
filetype='blah'
)
)
assert resp.status_code == 404
assert mock_get_service_template.called is False
def test_check_messages_should_revalidate_file_when_uploading_file(
logged_in_client,
service_one,

View File

@@ -185,6 +185,24 @@ def test_should_show_preview_letter_templates(
assert mocked_preview.call_args[0][1] == filetype
def test_dont_show_preview_letter_templates_for_bad_filetype(
logged_in_client,
mock_get_service_template,
service_one,
fake_uuid
):
resp = logged_in_client.get(
url_for(
'.view_letter_template_preview',
service_id=service_one['id'],
template_id=fake_uuid,
filetype='blah'
)
)
assert resp.status_code == 404
assert mock_get_service_template.called is False
def test_should_redirect_when_saving_a_template(
logged_in_client,
active_user_with_permissions,