From d59c3abf2b8990dd5b63531a0b4e54514a27f77c Mon Sep 17 00:00:00 2001 From: Leo Hemsted Date: Fri, 29 Nov 2019 12:35:04 +0000 Subject: [PATCH] combine flake8 configs also, importantly, remove the `select` config, as this implicitly ignores every other warning type --- .flake8 | 12 ++++++++++-- setup.cfg | 5 ----- 2 files changed, 10 insertions(+), 7 deletions(-) diff --git a/.flake8 b/.flake8 index f4f92e1bc..dc53bee7e 100644 --- a/.flake8 +++ b/.flake8 @@ -1,7 +1,15 @@ [flake8] # Rule definitions: http://flake8.pycqa.org/en/latest/user/error-codes.html -# W503: line break before binary operator exclude = venv*,__pycache__,node_modules,cache -ignore = W503 max-complexity = 14 max-line-length = 120 + +# B003 assigning to os.environ +# B306 BaseException.message has been deprecated +# W503: line break before binary operator +# W504 line break after binary operator +extend_ignore= + B003, + B306, + W503, + W504 diff --git a/setup.cfg b/setup.cfg index 0e515ccfe..e4b7097a7 100644 --- a/setup.cfg +++ b/setup.cfg @@ -9,8 +9,3 @@ multi_line_output=3 known_third_party=notifications_utils,notifications_python_client known_first_party=app,tests include_trailing_comma=True - -[flake8] -# W504 line break after binary operator -extend_ignore=B003, B306, W504 -select=B901, B902, B903