darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-09-11 10:28:41 -04:00
Code Issues Packages Projects Releases Wiki Activity

Change format of data sent to api when adding user to service

Browse Source 
The endpoint for adding a user to a service in api will now deal with
both user permissions and a user's folder permissions, so this changes
the format of the data we pass through.
This commit is contained in:
Katie Smith
2019-03-14 13:36:14 +00:00
parent 9fbe64bbd7
commit d3c256e80a
2 changed files with 5 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
app/notify_client/user_api_client.py
+4 -1
View File
@@ -153,7 +153,10 @@ class UserApiClient(NotifyAdminAPIClient):
def add_user_to_service(self, service_id, user_id, permissions): def add_user_to_service(self, service_id, user_id, permissions):
# permissions passed in are the combined admin roles, not db permissions # permissions passed in are the combined admin roles, not db permissions
endpoint = '/service/{}/users/{}'.format(service_id, user_id) endpoint = '/service/{}/users/{}'.format(service_id, user_id)
data = [{'permission': x} for x in translate_permissions_from_admin_roles_to_db(permissions)] data = {
'permissions': [{'permission': x} for x in translate_permissions_from_admin_roles_to_db(permissions)]
}
self.post(endpoint, data=data) self.post(endpoint, data=data)
@cache.delete('user-{user_id}') @cache.delete('user-{user_id}')
tests/app/notify_client/test_user_client.py
+1 -1
View File
@@ -154,7 +154,7 @@ def test_client_converts_admin_permissions_to_db_permissions_on_add_to_service(a
user_api_client.add_user_to_service('service_id', 'user_id', permissions={'send_messages', 'view_activity'}) user_api_client.add_user_to_service('service_id', 'user_id', permissions={'send_messages', 'view_activity'})
assert sorted(mock_post.call_args[1]['data'], key=lambda x: x['permission']) == sorted([ assert sorted(mock_post.call_args[1]['data']['permissions'], key=lambda x: x['permission']) == sorted([
{'permission': 'send_texts'}, {'permission': 'send_texts'},
{'permission': 'send_emails'}, {'permission': 'send_emails'},
{'permission': 'send_letters'}, {'permission': 'send_letters'},