darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-07-20 16:13:24 -04:00
Code Issues Packages Projects Releases Wiki Activity

Rename "parents" methods to "ancestors"

Browse Source 
Resolves: https://github.com/alphagov/notifications-admin/pull/3980#discussion_r694002952

A grandparent is not a parent, so the return value of these methods
were misleading. This makes it clearer.
This commit is contained in:
Ben Thorner
2021-08-23 16:48:21 +01:00
parent 1923c5edb1
commit d2784d0d8a
3 changed files with 9 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
app/templates/views/broadcast/libraries.html
View File

@@ -14,7 +14,7 @@
{{ page_header("Choose where to send this alert") }}
{% for area in broadcast_message.parent_areas %}
{% for area in broadcast_message.ancestor_areas %}
<a class="govuk-heading-m govuk-link govuk-link--no-visited-state" href="{{ url_for('.choose_broadcast_sub_area', service_id=current_service.id, broadcast_message_id=broadcast_message.id, library_slug=area.library_id, area_slug=area.id) }}">{{ area.name }}</a>
{% if loop.last %}
<div class="keyline-block"></div>