darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-08-25 00:33:58 -04:00
Code Issues Packages Projects Releases Wiki Activity

Give better names to usage page variables

Browse Source 
`free` becomes `sms_free_count`
`paid` becomes `sms_paid_count`

This small change is just to help with readability for this
complex area of code
This commit is contained in:
David McDonald
2022-04-25 11:27:03 +01:00
parent c5d729b5f2
commit d18c787a02
3 changed files with 21 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
tests/app/main/views/test_dashboard.py
View File

@@ -1595,18 +1595,18 @@ def test_get_free_paid_breakdown_for_billable_units(now, expected_number_of_mont
]
)
assert list(billing_units) == [
{'free': 100000, 'name': 'April', 'paid': 0, 'letter_total': 0, 'letters': []},
{'free': 100000, 'name': 'May', 'paid': 0, 'letter_total': 0, 'letters': []},
{'free': 50000, 'name': 'June', 'paid': 50000, 'letter_total': 0, 'letters': []},
{'free': 0, 'name': 'July', 'paid': 0, 'letter_total': 0, 'letters': []},
{'free': 0, 'name': 'August', 'paid': 0, 'letter_total': 0, 'letters': []},
{'free': 0, 'name': 'September', 'paid': 0, 'letter_total': 0, 'letters': []},
{'free': 0, 'name': 'October', 'paid': 0, 'letter_total': 0, 'letters': []},
{'free': 0, 'name': 'November', 'paid': 0, 'letter_total': 0, 'letters': []},
{'free': 0, 'name': 'December', 'paid': 0, 'letter_total': 0, 'letters': []},
{'free': 0, 'name': 'January', 'paid': 0, 'letter_total': 0, 'letters': []},
{'free': 0, 'name': 'February', 'paid': 2000, 'letter_total': 0, 'letters': []},
{'free': 0, 'name': 'March', 'paid': 0, 'letter_total': 0, 'letters': []}
{'sms_free_count': 100000, 'name': 'April', 'sms_paid_count': 0, 'letter_total': 0, 'letters': []},
{'sms_free_count': 100000, 'name': 'May', 'sms_paid_count': 0, 'letter_total': 0, 'letters': []},
{'sms_free_count': 50000, 'name': 'June', 'sms_paid_count': 50000, 'letter_total': 0, 'letters': []},
{'sms_free_count': 0, 'name': 'July', 'sms_paid_count': 0, 'letter_total': 0, 'letters': []},
{'sms_free_count': 0, 'name': 'August', 'sms_paid_count': 0, 'letter_total': 0, 'letters': []},
{'sms_free_count': 0, 'name': 'September', 'sms_paid_count': 0, 'letter_total': 0, 'letters': []},
{'sms_free_count': 0, 'name': 'October', 'sms_paid_count': 0, 'letter_total': 0, 'letters': []},
{'sms_free_count': 0, 'name': 'November', 'sms_paid_count': 0, 'letter_total': 0, 'letters': []},
{'sms_free_count': 0, 'name': 'December', 'sms_paid_count': 0, 'letter_total': 0, 'letters': []},
{'sms_free_count': 0, 'name': 'January', 'sms_paid_count': 0, 'letter_total': 0, 'letters': []},
{'sms_free_count': 0, 'name': 'February', 'sms_paid_count': 2000, 'letter_total': 0, 'letters': []},
{'sms_free_count': 0, 'name': 'March', 'sms_paid_count': 0, 'letter_total': 0, 'letters': []}
][:expected_number_of_months]