darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-08-25 08:44:23 -04:00
Code Issues Packages Projects Releases Wiki Activity

maybe fix tests? Or else calculations are all wrong

Browse Source
This commit is contained in:
Kenneth Kehl
2023-11-22 12:37:57 -08:00
parent 8c7db5d7e1
commit d10d3f7c00
1 changed files with 12 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

25
tests/app/main/views/test_templates.py
View File

@@ -1966,18 +1966,11 @@ def test_set_template_sender(
@pytest.mark.parametrize( @pytest.mark.parametrize(
("template_type", "prefix_sms", "content", "expected_message", "expected_class"), ("template_type", "prefix_sms", "content", "expected_message", "expected_class"),
[ [
(
"sms",
False,
"",
"Will be charged as 1 text message",
None,
),
( (
"sms", "sms",
False, False,
"a" * 160, "a" * 160,
"Will be charged as 1 text message", "Will be charged as 2 text messages",
None, None,
), ),
( (
@@ -1988,11 +1981,10 @@ def test_set_template_sender(
None, None,
), ),
( (
# service name takes 13 characters, 147 + 13 = 160
"sms", "sms",
True, True,
"a" * 147, "a" * 147,
"Will be charged as 1 text message", "Will be charged as 2 text messages",
None, None,
), ),
( (
@@ -2007,7 +1999,7 @@ def test_set_template_sender(
"sms", "sms",
False, False,
"a" * 918, "a" * 918,
"Will be charged as 6 text messages", "Will be charged as 7 text messages",
None, None,
), ),
( (
@@ -2048,8 +2040,11 @@ def test_set_template_sender(
( (
"sms", "sms",
False, False,
# The length of this string in bytes is 210, needing two fragments.
# Seems like previous calculation was wrong unless the number of characters
# somehow has priority over the number of bytes in a fragment (?)
"Ẅ" * 70, "Ẅ" * 70,
"Will be charged as 1 text message", "Will be charged as 2 text messages",
None, None,
), ),
( (
@@ -2063,7 +2058,11 @@ def test_set_template_sender(
"sms", "sms",
False, False,
"Ẅ" * 918, "Ẅ" * 918,
"Will be charged as 14 text messages", # The length of this string in bytes is 2754. Divide by 140 and we get 19. Then round up.
# Don't know why it was previously calculated as 14. They seem to have charged by characters
# rather than length of the fragment in bytes.
# "Will be charged as 14 text messages",
"Will be charged as 20 text messages",
None, None,
), ),
( (