darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-07-11 04:03:51 -04:00
Code Issues Packages Projects Releases Wiki Activity

Fixed broken edit functionality

Browse Source
This commit is contained in:
chrisw
2017-10-30 14:30:43 +00:00
parent dd88d007e1
commit d02cd67b0d
5 changed files with 31 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
tests/app/main/test_validators.py
View File

@@ -1,5 +1,5 @@
import pytest
from app.main.forms import RegisterUserForm, ServiceSmsSender
from app.main.forms import RegisterUserForm, ServiceSmsSenderForm
from app.main.validators import ValidGovEmail, NoCommasInPlaceHolders, OnlyGSMCharacters
from wtforms import ValidationError
from unittest.mock import Mock
@@ -184,7 +184,7 @@ def test_sms_sender_form_validation(
client,
mock_get_user_by_email,
):
form = ServiceSmsSender()
form = ServiceSmsSenderForm()
form.sms_sender.data = 'elevenchars'
form.validate()

12
tests/app/main/views/test_service_settings.py
View File

@@ -1060,10 +1060,10 @@ def test_edit_letter_contact_block(
@pytest.mark.parametrize('fixture, data, api_default_args', [
(get_default_sms_sender, {"is_default": "y"}, True),
(get_default_sms_sender, {}, True),
(get_non_default_sms_sender, {}, False),
(get_non_default_sms_sender, {"is_default": "y"}, True)
(get_default_sms_sender, {"is_default": "y", "sms_sender": "test"}, True),
(get_default_sms_sender, {"sms_sender": "test"}, True),
(get_non_default_sms_sender, {"sms_sender": "test"}, False),
(get_non_default_sms_sender, {"is_default": "y", "sms_sender": "test"}, True)
])
def test_edit_sms_sender(
fixture,
@@ -1085,7 +1085,7 @@ def test_edit_sms_sender(
mock_update_sms_sender.assert_called_once_with(
SERVICE_ONE_ID,
sms_sender_id=fake_uuid,
sms_sender="GOVUK",
sms_sender="test",
is_default=api_default_args
)
@@ -1184,7 +1184,7 @@ def test_inbound_sms_sender_is_not_editable(
sms_sender_id=fixture_sender_id,
)
assert (page.select_one('main input[name="sms_sender"]') is None) == hide_textbox
assert bool(page.find('input', attrs={'name': "sms_sender"})) != hide_textbox
if hide_textbox:
assert normalize_spaces(
page.select_one('form[method="post"] p').text