darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-05-04 16:11:11 -04:00
Code Issues Packages Projects Releases Wiki Activity

Mapped template actions to the api and mocked tests.

Browse Source
This commit is contained in:
Nicholas Staples
2016-01-19 15:54:12 +00:00
parent e2f5d64695
commit cfb3f96b01
13 changed files with 321 additions and 88 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
tests/__init__.py
View File

@@ -29,6 +29,16 @@ def service_json(id_, name, users, limit=1000, active=False, restricted=True):
}
def template_json(id_, name, type_, content, service_id):
return {
'id': id_,
'name': name,
'template_type': type_,
'content': content,
'service': service_id
}
TEST_USER_EMAIL = 'test@user.gov.uk'

103
tests/app/main/views/test_templates.py
View File

@@ -1,49 +1,128 @@
import json
from flask import url_for
def test_should_return_list_of_all_templates(app_, db_, db_session, active_user):
def test_should_return_list_of_all_templates(app_,
db_,
db_session,
active_user,
mock_get_service_templates):
with app_.test_request_context():
with app_.test_client() as client:
client.login(active_user)
response = client.get(url_for('.manage_templates', service_id=123))
service_id = 123
response = client.get(url_for(
'.manage_service_templates', service_id=service_id))
assert response.status_code == 200
mock_get_service_templates.assert_called_with(service_id)
def test_should_show_page_for_one_templates(app_, db_, db_session, active_user):
def test_should_show_page_for_one_templates(app_,
db_,
db_session,
active_user,
mock_get_service_template):
with app_.test_request_context():
with app_.test_client() as client:
client.login(active_user)
response = client.get(url_for('.edit_template', service_id=123, template_id=1))
service_id = 123
template_id = 456
response = client.get(url_for(
'.edit_service_template',
service_id=service_id,
template_id=template_id))
assert response.status_code == 200
mock_get_service_template.assert_called_with(
service_id, template_id)
def test_should_redirect_when_saving_a_template(app_, db_, db_session, active_user):
def test_should_redirect_when_saving_a_template(app_,
db_,
db_session,
active_user,
mock_get_service_template,
mock_update_service_template):
with app_.test_request_context():
with app_.test_client() as client:
client.login(active_user)
response = client.post(url_for('.edit_template', service_id=123, template_id=1))
service_id = 123
template_id = 456
name = "new name"
type_ = "sms"
content = "template content"
data = {
'id': template_id,
'name': name,
'template_type': type_,
"content": content,
"service": service_id
}
response = client.post(url_for(
'.edit_service_template',
service_id=service_id,
template_id=template_id), data=data)
assert response.status_code == 302
assert response.location == url_for('.manage_templates', service_id=123, _external=True)
assert response.location == url_for(
'.manage_service_templates', service_id=service_id, _external=True)
mock_update_service_template.assert_called_with(
template_id, name, type_, content, service_id)
def test_should_show_delete_template_page(app_, db_, db_session, active_user):
def test_should_show_delete_template_page(app_,
db_,
db_session,
active_user,
mock_get_service_template):
with app_.test_request_context():
with app_.test_client() as client:
client.login(active_user)
response = client.get(url_for('.delete_template', service_id=123, template_id=1))
service_id = 123
template_id = 456
response = client.get(url_for(
'.delete_service_template',
service_id=service_id,
template_id=template_id))
assert response.status_code == 200
assert 'Are you sure' in response.get_data(as_text=True)
mock_get_service_template.assert_called_with(
service_id, template_id)
def test_should_redirect_when_deleting_a_template(app_, db_, db_session, active_user):
def test_should_redirect_when_deleting_a_template(app_,
db_,
db_session,
active_user,
mock_get_service_template,
mock_delete_service_template):
with app_.test_request_context():
with app_.test_client() as client:
client.login(active_user)
response = client.post(url_for('.delete_template', service_id=123, template_id=1))
service_id = 123
template_id = 456
name = "new name"
type_ = "sms"
content = "template content"
data = {
'id': template_id,
'name': name,
'template_type': type_,
'content': content,
'service': service_id
}
response = client.post(url_for(
'.delete_service_template',
service_id=service_id,
template_id=template_id), data=data)
assert response.status_code == 302
assert response.location == url_for('.manage_templates', service_id=123, _external=True)
assert response.location == url_for(
'.manage_service_templates',
service_id=service_id, _external=True)
mock_get_service_template.assert_called_with(
service_id, template_id)
mock_delete_service_template.assert_called_with(
service_id, template_id)

66
tests/conftest.py
View File

@@ -7,7 +7,7 @@ from flask.ext.script import Manager
from sqlalchemy.schema import MetaData
from . import (
create_test_user, create_another_test_user, service_json, TestClient,
get_test_user)
get_test_user, template_json)
from app import create_app, db
@@ -94,12 +94,11 @@ def mock_get_service(mocker, active_user):
@pytest.fixture(scope='function')
def mock_create_service(mocker):
# TODO fix token generation
def _create(service_name, active, limit, restricted, user_id):
service = service_json(
101, service_name, [user_id], limit=limit,
active=active, restricted=restricted)
return {'data': service, 'token': 1}
return {'data': service}
mock_class = mocker.patch(
'app.notifications_api_client.create_service', side_effect=_create)
return mock_class
@@ -142,3 +141,64 @@ def mock_delete_service(mocker, mock_get_service):
mock_class = mocker.patch(
'app.notifications_api_client.delete_service', side_effect=_delete)
return mock_class
@pytest.fixture(scope='function')
def mock_get_service_template(mocker):
def _create(service_id, template_id):
template = template_json(
template_id, "Template Name", "sms", "template content", service_id)
return {'data': template}
return mocker.patch(
'app.notifications_api_client.get_service_template',
side_effect=_create)
@pytest.fixture(scope='function')
def mock_create_service_template(mocker):
def _create(name, type_, content, service):
template = template_json(
101, name, type_, content, service)
return {'data': template}
mock_class = mocker.patch(
'app.notifications_api_client.create_service_template',
side_effect=_create)
return mock_class
@pytest.fixture(scope='function')
def mock_update_service_template(mocker):
def _update(id_, name, type_, content, service):
template = template_json(
id_, name, type_, content, service)
return {'data': template}
mock_class = mocker.patch(
'app.notifications_api_client.update_service_template',
side_effect=_update)
return mock_class
@pytest.fixture(scope='function')
def mock_get_service_templates(mocker):
def _create(service_id):
template_one = template_json(
1, "template_one", "sms", "template one content", service_id)
template_two = template_json(
2, "template_two", "sms", "template two content", service_id)
return {'data': [template_one, template_two]}
mock_class = mocker.patch(
'app.notifications_api_client.get_service_templates',
side_effect=_create)
return mock_class
@pytest.fixture(scope='function')
def mock_delete_service_template(mocker):
def _delete(service_id, template_id):
template = template_json(
template_id, "Template to delete",
"sms", "content to be deleted", service_id)
return {'data': template}
mock_class = mocker.patch(
'app.notifications_api_client.delete_service_template', side_effect=_delete)
return mock_class