darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-08-14 23:08:07 -04:00
Code Issues Packages Projects Releases Wiki Activity

Make it clearer what you’re downloading

Browse Source 
The previous text didn’t make it clear _what_ you were downloading as a
CSV file, you had to infer it from the context.

And the fact that it’s a CSV file is immaterial, it’s the data you care
about, not the format.
This commit is contained in:
Chris Hill-Scott
2016-07-18 08:36:44 +01:00
parent 500a503f07
commit cfadead292
2 changed files with 5 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
app/templates/partials/jobs/notifications.html
View File

@@ -6,9 +6,9 @@
{% if notifications and not help %} {% if notifications and not help %}
<p class="bottom-gutter"> <p class="bottom-gutter">
<a href="{{ url_for('.view_job_csv', service_id=current_service.id, job_id=job.id, status=status) }}" download="download" class="heading-small">Download as a CSV file</a> <a href="{{ url_for('.view_job_csv', service_id=current_service.id, job_id=job.id, status=status) }}" download="download" class="heading-small">Download this report</a>
&emsp; &emsp;
Delivery information is available for 7 days Available for 7 days
</p> </p>
{% endif %} {% endif %}

4
tests/app/main/views/test_jobs.py
View File

@@ -90,12 +90,14 @@ def test_should_show_page_for_one_job(
job_id=fake_uuid, job_id=fake_uuid,
status=status_argument, status=status_argument,
) )
assert page.find('a', {'download': 'download'})['href'] == url_for( csv_link = page.find('a', {'download': 'download'})
assert csv_link['href'] == url_for(
'main.view_job_csv', 'main.view_job_csv',
service_id=service_one['id'], service_id=service_one['id'],
job_id=fake_uuid, job_id=fake_uuid,
status=status_argument status=status_argument
) )
assert csv_link.text == 'Download this report'
mock_get_notifications.assert_called_with( mock_get_notifications.assert_called_with(
service_one['id'], service_one['id'],
fake_uuid, fake_uuid,