darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-02-05 10:53:28 -05:00
Code Issues Packages Projects Releases Wiki Activity

Take out the Canadian politeness.

Browse Source 
Make the error message more consistent.
Extracted common fields for the forms.
This commit is contained in:
Rebecca Law
2016-01-08 12:00:52 +00:00
parent f951b364ac
commit ceb78f49b4
4 changed files with 58 additions and 60 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
tests/app/main/views/test_add_service.py
View File

@@ -39,4 +39,4 @@ def test_should_return_form_errors_when_service_name_is_empty(notifications_admi
client.post('/two-factor', data={'sms_code': '12345'})
response = client.post('/add-service', data={})
assert response.status_code == 200
assert 'Please enter your service name' in response.get_data(as_text=True)
assert 'Service name can not be empty' in response.get_data(as_text=True)

4
tests/app/main/views/test_register.py
View File

@@ -31,7 +31,7 @@ def test_process_register_returns_400_when_mobile_number_is_invalid(notification
'password': 'validPassword!'})
assert response.status_code == 200
assert 'Please enter a +44 mobile number' in response.get_data(as_text=True)
assert 'Enter a +44 mobile number' in response.get_data(as_text=True)
def test_should_return_400_when_email_is_not_gov_uk(notifications_admin,
@@ -46,7 +46,7 @@ def test_should_return_400_when_email_is_not_gov_uk(notifications_admin,
'password': 'validPassword!'})
assert response.status_code == 200
assert 'Please enter a gov.uk email address' in response.get_data(as_text=True)
assert 'Enter a gov.uk email address' in response.get_data(as_text=True)
def test_should_add_verify_codes_on_session(notifications_admin, notifications_admin_db, mocker, notify_db_session):