darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-09-08 07:28:25 -04:00
Code Issues Packages Projects Releases Wiki Activity

Test for VerifyForm and TwoFactorForm

Browse Source
This commit is contained in:
Rebecca Law
2015-12-14 14:09:29 +00:00
parent 295dbeb7d1
commit caabda92e0
4 changed files with 9 additions and 33 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
app/main/forms.py
View File

@@ -71,7 +71,7 @@ class VerifyForm(Form):
def validate_code(field, code): def validate_code(field, code):
if code.expiry_datetime > datetime.now(): if code.expiry_datetime <= datetime.now():
field.errors.append('Code has expired') field.errors.append('Code has expired')
return False return False
if field.data is not None: if field.data is not None:

6
tests/app/main/test_two_factor_form.py
View File

@@ -50,11 +50,11 @@ def test_returns_errors_when_code_contains_letters(notifications_admin, notifica
def test_should_return_errors_when_code_is_expired(notifications_admin, notifications_admin_db, notify_db_session): def test_should_return_errors_when_code_is_expired(notifications_admin, notifications_admin_db, notify_db_session):
with notifications_admin.test_request_context(method='POST', with notifications_admin.test_request_context(method='POST',
data={'sms_code': '12345'}) as req: data={'sms_code': '23456'}) as req:
user = set_up_test_data() user = create_test_user()
req.session['user_id'] = user.id req.session['user_id'] = user.id
verify_codes_dao.add_code_with_expiry(user_id=user.id, verify_codes_dao.add_code_with_expiry(user_id=user.id,
code='12345', code='23456',
code_type='sms', code_type='sms',
expiry=datetime.now() + timedelta(hours=-2)) expiry=datetime.now() + timedelta(hours=-2))
req.session['user_id'] = user.id req.session['user_id'] = user.id

10
tests/app/main/test_verify_form.py
View File

@@ -49,7 +49,7 @@ def test_should_return_errors_when_code_is_too_short(notifications_admin, notifi
def test_should_return_errors_when_code_does_not_match(notifications_admin, notifications_admin_db, notify_db_session): def test_should_return_errors_when_code_does_not_match(notifications_admin, notifications_admin_db, notify_db_session):
with notifications_admin.test_request_context(method='POST', with notifications_admin.test_request_context(method='POST',
data={'sms_code': '23456', 'email_code': '23456'}) as req: data={'sms_code': '34567', 'email_code': '34567'}) as req:
user = set_up_test_data() user = set_up_test_data()
req.session['user_id'] = user.id req.session['user_id'] = user.id
form = VerifyForm(req.request.form) form = VerifyForm(req.request.form)
@@ -65,7 +65,7 @@ def test_should_return_errors_when_code_is_expired(notifications_admin, notifica
with notifications_admin.test_request_context(method='POST', with notifications_admin.test_request_context(method='POST',
data={'sms_code': '23456', data={'sms_code': '23456',
'email_code': '23456'}) as req: 'email_code': '23456'}) as req:
user = set_up_test_data() user = create_test_user()
req.session['user_id'] = user.id req.session['user_id'] = user.id
verify_codes_dao.add_code_with_expiry(user_id=user.id, verify_codes_dao.add_code_with_expiry(user_id=user.id,
code='23456', code='23456',
@@ -80,10 +80,10 @@ def test_should_return_errors_when_code_is_expired(notifications_admin, notifica
form = VerifyForm(req.request.form) form = VerifyForm(req.request.form)
assert form.validate() is False assert form.validate() is False
errors = form.errors errors = form.errors
expected = set({'sms_code': ['Code has expired'], expected = {'sms_code': ['Code has expired'],
'email_code': ['Code has exprired']}) 'email_code': ['Code has expired']}
assert len(errors) == 2 assert len(errors) == 2
assert set(errors) == expected assert set(errors) == set(expected)
def set_up_test_data(): def set_up_test_data():

24
tests/app/main/views/test_two_factor.py
View File

@@ -35,27 +35,3 @@ def test_should_return_400_with_sms_code_error_when_sms_code_is_wrong(notificati
data={'sms_code': '23456'}) data={'sms_code': '23456'})
assert response.status_code == 400 assert response.status_code == 400
assert {'sms_code': ['Code does not match']} == json.loads(response.get_data(as_text=True)) assert {'sms_code': ['Code does not match']} == json.loads(response.get_data(as_text=True))
def test_should_return_400_when_sms_code_is_empty(notifications_admin, notifications_admin_db, notify_db_session):
with notifications_admin.test_client() as client:
with client.session_transaction() as session:
user = create_test_user()
session['user_id'] = user.id
verify_codes_dao.add_code(user_id=user.id, code='12345', code_type='sms')
response = client.post('/two-factor')
assert response.status_code == 400
assert {'sms_code': ['Please enter your code']} == json.loads(response.get_data(as_text=True))
def test_should_return_400_when_sms_code_is_too_short(notifications_admin, notifications_admin_db, notify_db_session):
with notifications_admin.test_client() as client:
with client.session_transaction() as session:
user = create_test_user()
session['user_id'] = user.id
verify_codes_dao.add_code(user_id=user.id, code='23467', code_type='sms')
response = client.post('/two-factor', data={'sms_code': '2346'})
assert response.status_code == 400
data = json.loads(response.get_data(as_text=True))
assert len(data.keys()) == 1
assert set(data) == set({'sms_code': ['Code must be 5 digits', 'Code does not match']})