darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-08-24 00:07:02 -04:00
Code Issues Packages Projects Releases Wiki Activity

Add PlatformStatsAPIClient

Browse Source 
In API, the endpoint for the new platform admin stats page has been
moved to a platform stats blueprint. This means we now need a platform
stats client.
This commit is contained in:
Katie Smith
2018-06-28 10:28:57 +01:00
parent d9aeac4dca
commit ca16bef7f7
7 changed files with 34 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
tests/app/main/views/test_platform_admin.py
View File

@@ -702,7 +702,7 @@ def test_platform_admin_new_with_start_and_end_dates_provided(mocker, logged_in_
mocker.patch('app.main.views.platform_admin.make_columns')
aggregate_stats_mock = mocker.patch(
'app.main.views.platform_admin.service_api_client.get_new_aggregate_platform_stats')
'app.main.views.platform_admin.platform_stats_api_client.get_aggregate_platform_stats')
complaint_count_mock = mocker.patch('app.main.views.platform_admin.complaint_api_client.get_complaint_count')
logged_in_platform_admin_client.get(
@@ -720,7 +720,7 @@ def test_platform_admin_new_with_only_a_start_date_provided(mocker, logged_in_pl
mocker.patch('app.main.views.platform_admin.make_columns')
aggregate_stats_mock = mocker.patch(
'app.main.views.platform_admin.service_api_client.get_new_aggregate_platform_stats')
'app.main.views.platform_admin.platform_stats_api_client.get_aggregate_platform_stats')
complaint_count_mock = mocker.patch('app.main.views.platform_admin.complaint_api_client.get_complaint_count')
logged_in_platform_admin_client.get(url_for('main.platform_admin_new', start_date=start_date))
@@ -734,7 +734,7 @@ def test_platform_admin_new_without_dates_provided(mocker, logged_in_platform_ad
mocker.patch('app.main.views.platform_admin.make_columns')
aggregate_stats_mock = mocker.patch(
'app.main.views.platform_admin.service_api_client.get_new_aggregate_platform_stats')
'app.main.views.platform_admin.platform_stats_api_client.get_aggregate_platform_stats')
complaint_count_mock = mocker.patch('app.main.views.platform_admin.complaint_api_client.get_complaint_count')
logged_in_platform_admin_client.get(url_for('main.platform_admin_new'))
@@ -761,7 +761,7 @@ def test_platform_admin_new_displays_stats_in_right_boxes_and_with_correct_styli
'test-key': 0,
'total': 500}
}
mocker.patch('app.main.views.platform_admin.service_api_client.get_new_aggregate_platform_stats',
mocker.patch('app.main.views.platform_admin.platform_stats_api_client.get_aggregate_platform_stats',
return_value=platform_stats)
mocker.patch('app.main.views.platform_admin.complaint_api_client.get_complaint_count', return_value=15)

10
tests/app/notify_client/test_platform_stats_api_client.py Normal file
View File

@@ -0,0 +1,10 @@
from app.notify_client.platform_stats_api_client import PlatformStatsAPIClient
def test_get_aggregate_platform_stats(mocker):
client = PlatformStatsAPIClient()
mock = mocker.patch.object(client, 'get')
params_dict = {'start_date': '2018-06-01', 'end_date': '2018-06-15'}
client.get_aggregate_platform_stats(params_dict=params_dict)
mock.assert_called_once_with('/platform-stats', params=params_dict)

9
tests/app/notify_client/test_service_api_client.py
View File

@@ -53,15 +53,6 @@ def test_client_only_updates_allowed_attributes(mocker):
assert str(error.value) == 'Not allowed to update service attributes: foo'
def test_get_new_aggregate_platform_stats(mocker):
client = ServiceAPIClient()
mock = mocker.patch.object(client, 'get')
params_dict = {'start_date': '2018-06-01', 'end_date': '2018-06-15'}
client.get_new_aggregate_platform_stats(params_dict=params_dict)
mock.assert_called_once_with('/service/platform-stats-new', params=params_dict)
def test_client_creates_service_with_correct_data(
mocker,
active_user_with_permissions,