darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-08-18 13:39:41 -04:00
Code Issues Packages Projects Releases Wiki Activity

Refactor to use address validation in utils

Browse Source
This commit is contained in:
Ken Tsang
2017-06-15 10:48:22 +01:00
parent 338df098a8
commit c8f72bc513
2 changed files with 9 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
tests/app/main/views/test_send.py
View File

@@ -1529,7 +1529,7 @@ def test_check_messages_shows_over_max_row_error(
)
def test_special_characters_in_dvla_recipients_file_shows_error(
def test_special_characters_in_letter_recipients_file_shows_error(
logged_in_client,
mock_get_users_by_service,
mock_get_service,
@@ -1543,20 +1543,25 @@ def test_special_characters_in_dvla_recipients_file_shows_error(
mock_recipients = mocker.patch('app.utils.Spreadsheet.from_file').return_value
mock_recipients.as_dict = {
'file_name': 'invalid_characters.csv', 'data':
'address line 1,address line 2,address line 3,address line 4,address line 5,address line 6,postcode\r\n'\
'address line 1,address line 2,address line 3,address line 4,address line 5,address line 6,postcode\r\n'
'B. √Name,345 Example Street,,,,,ZM4 6HQ©'
}
response = logged_in_client.post(
url_for('main.send_messages', service_id=SERVICE_ONE_ID, template_id=fake_uuid),
data={'file': (None, 'invalid_characters.csv')},
follow_redirects=True
)
assert response.status_code == 200
page = BeautifulSoup(response.data.decode('utf-8'), 'html.parser')
assert ' '.join(
page.find('div', class_='banner-dangerous').text.split()
) == 'Invalid characters in the address fields within invalid_characters.csv.'
) == (
'There is a problem with your data '
'You need to fix 1 address '
'Skip to file contents'
)
def test_check_messages_redirects_if_no_upload_data(logged_in_client, service_one, mocker):