darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-08-19 14:09:20 -04:00
Code Issues Packages Projects Releases Wiki Activity

fix pdf download link trying to request a page count

Browse Source 
It doesn't make sense to get a pdf for only one page - the template
preview app just returns a 400 if you try. So we shouldn't try!
This commit is contained in:
Leo Hemsted
2018-10-15 14:02:13 +01:00
parent 6154495c1b
commit c898284c3b
3 changed files with 35 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
app/main/views/platform_admin.py
View File

@@ -266,7 +266,7 @@ def platform_admin_letter_validation_preview():
if response.status_code == 200:
pages, message, result = response.json()["pages"], response.json()["message"], response.json()["result"]
except RequestException as error:
if error.response.status_code == 400:
if error.response and error.response.status_code == 400:
message = "Something was wrong with the file you tried to upload. Please upload a valid PDF file."
return render_template(
'views/platform-admin/letter-validation-preview.html',