darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-09-07 10:08:25 -04:00
Code Issues Packages Projects Releases Wiki Activity

Fix create SMS template

Browse Source 
When creating an SMS template the form validation was looking for a subject.
SMS messages don’t have a subject.
This commit is contained in:
Chris Hill-Scott
2016-02-25 10:32:57 +00:00
parent 602d505dc7
commit c733b4318e
3 changed files with 6 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
app/main/views/templates.py
View File

@@ -31,7 +31,11 @@ def add_service_template(service_id, template_type):
if form.validate_on_submit(): if form.validate_on_submit():
tdao.insert_service_template( tdao.insert_service_template(
form.name.data, template_type, form.template_content.data, service_id, form.subject.data or None form.name.data,
template_type,
form.template_content.data,
service_id,
form.subject.data if hasattr(form, 'subject') else None
) )
return redirect( return redirect(
url_for('.choose_template', service_id=service_id, template_type=template_type) url_for('.choose_template', service_id=service_id, template_type=template_type)

6
app/templates/views/edit-email-template.html
View File

@@ -14,12 +14,8 @@
<div class="grid-row"> <div class="grid-row">
<div class="column-two-thirds"> <div class="column-two-thirds">
{{ textbox(form.name, width='1-1') }} {{ textbox(form.name, width='1-1') }}
{% if 'email' == template_type %} {{ textbox(form.subject, width='1-1') }}
{{ textbox(form.subject, width='1-1') }}
{% endif %}
</div> </div>
</div>
<div class="grid-row">
<div class="column-two-thirds"> <div class="column-two-thirds">
{{ textbox(form.template_content, highlight_tags=True, width='1-1') }} {{ textbox(form.template_content, highlight_tags=True, width='1-1') }}
</div> </div>

5
app/templates/views/edit-sms-template.html
View File

@@ -14,12 +14,7 @@
<div class="grid-row"> <div class="grid-row">
<div class="column-two-thirds"> <div class="column-two-thirds">
{{ textbox(form.name, width='1-1') }} {{ textbox(form.name, width='1-1') }}
{% if 'email' == template_type %}
{{ textbox(form.subject, width='1-1') }}
{% endif %}
</div> </div>
</div>
<div class="grid-row">
<div class="column-two-thirds"> <div class="column-two-thirds">
{{ textbox(form.template_content, highlight_tags=True, width='1-1') }} {{ textbox(form.template_content, highlight_tags=True, width='1-1') }}
</div> </div>