darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-08-23 15:57:23 -04:00
Code Issues Packages Projects Releases Wiki Activity

Add notes to edit billing details page

Browse Source 
As per ticket and as per Caley's request, so everything can be
edited together.

Also pluralise labels for billing contact info, to indicate
that putting multiple in is ok, and widen the input fields so
that it is more comfortable to input multiple contact details.
This commit is contained in:
Pea Tyczynska
2021-01-27 18:20:25 +00:00
parent 079f371bc5
commit c60be7000a
4 changed files with 36 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
tests/app/main/views/test_service_settings.py
View File

@@ -5312,18 +5312,27 @@ def test_view_edit_service_billing_details(
assert page.select_one('h1').text == "Change billing details"
labels = page.find_all('label', class_="form-label")
labels_list = [
'Billing contact email address', 'Billing contact name', 'Billing reference', 'Purchase order number'
'Billing contact email addresses',
'Billing contact names',
'Billing reference',
'Purchase order number',
'Notes'
]
for label in labels:
assert label.text.strip() in labels_list
textbox_names = page.find_all('input', class_='govuk-input govuk-!-width-two-thirds')
textbox_names = page.find_all('input', class_='govuk-input govuk-!-width-full')
names_list = [
'billing_contact_email_addresses', 'billing_contact_names', 'billing_reference', 'purchase_order_number'
'billing_contact_email_addresses',
'billing_contact_names',
'billing_reference',
'purchase_order_number',
]
for name in textbox_names:
assert name.attrs["name"] in names_list
assert page.find('textarea').attrs["name"] == "notes"
def test_update_service_billing_details(
platform_admin_client,
@@ -5339,7 +5348,8 @@ def test_update_service_billing_details(
'billing_contact_email_addresses': 'accounts@fluff.gov.uk',
'billing_contact_names': 'Flannellette von Fluff',
'billing_reference': '',
'purchase_order_number': 'PO1234'
'purchase_order_number': 'PO1234',
'notes': 'very fluffy, give extra allowance'
}
)
assert response.status_code == 302
@@ -5351,5 +5361,6 @@ def test_update_service_billing_details(
billing_contact_email_addresses='accounts@fluff.gov.uk',
billing_contact_names='Flannellette von Fluff',
billing_reference='',
purchase_order_number='PO1234'
purchase_order_number='PO1234',
notes='very fluffy, give extra allowance'
)