darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-09-05 18:18:25 -04:00
Code Issues Packages Projects Releases Wiki Activity

Removed unneeded parameters after update to api.

Browse Source 
Updated the tests to take the removal into account.

Tidied up unused imports
This commit is contained in:
Richard Chapman
2018-02-28 17:12:36 +00:00
committed by Ken Tsang
parent 6279169b18
commit c52657146a
2 changed files with 1 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
app/main/views/notifications.py
View File

@@ -1,6 +1,5 @@
# -*- coding: utf-8 -*- # -*- coding: utf-8 -*-
import base64 import base64
from collections import ItemsView
from datetime import datetime from datetime import datetime
from flask import ( from flask import (
@@ -116,7 +115,6 @@ def view_letter_notification_as_preview(service_id, notification_id, filetype):
page=request.args.get('page') page=request.args.get('page')
) )
# return base64.b64decode(preview['content']), preview['status'], ItemsView(dict(preview['headers']))
return base64.b64decode(preview['content']) return base64.b64decode(preview['content'])

4
tests/app/main/views/test_notifications.py
View File

@@ -167,9 +167,7 @@ def test_should_show_image_of_letter_notification(
mocked_api_client = mocker.patch( mocked_api_client = mocker.patch(
'app.notify_client.notification_api_client.NotificationApiClient.get', 'app.notify_client.notification_api_client.NotificationApiClient.get',
return_value={ return_value={
'content': base64.b64encode(b'foo').decode('utf-8'), 'content': base64.b64encode(b'foo').decode('utf-8')
'status': 200,
'headers': [{'test': 'test', 'test1': 'test1'}]
} }
) )