darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-09-02 17:48:50 -04:00
Code Issues Packages Projects Releases Wiki Activity

only get template statistics for specific template

Browse Source
This commit is contained in:
Leo Hemsted
2016-06-07 14:28:02 +01:00
parent 9db20819ef
commit c4305d1610
5 changed files with 51 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
app/main/views/templates.py
View File

@@ -186,8 +186,8 @@ def delete_service_template(service_id, template_id):
template['template_content'] = template['content']
form = form_objects[template['template_type']](**template)
template_statistics = template_statistics_client.get_template_statistics_for_service(service_id)
last_use_message = get_last_use_message(form.name.data, template['id'], template_statistics)
template_statistics = template_statistics_client.get_template_statistics_for_service(service_id, template['id'])
last_use_message = get_last_use_message(form.name.data, template_statistics)
flash('{}. Are you sure you want to delete it?'.format(last_use_message), 'delete')
return render_template(
'views/edit-{}-template.html'.format(template['template_type']),
@@ -223,12 +223,11 @@ def view_template_versions(service_id, template_id):
)
def get_last_use_message(template_name, template_id, template_statistics):
def get_last_use_message(template_name, template_statistics):
try:
most_recent_use = max(
parse(template_stats['updated_at']).replace(tzinfo=None)
for template_stats in template_statistics
if template_stats['template']['id'] == template_id
)
except ValueError:
return '{} has never been used'.format(template_name)

5
app/notify_client/template_statistics_api_client.py
View File

@@ -20,3 +20,8 @@ class TemplateStatisticsApiClient(BaseAPIClient):
url='/service/{}/template-statistics'.format(service_id),
params=params
)['data']
def get_template_statistics_for_template(self, service_id, template_id):
return self.get(
url='/service/{}/template-statistics/{}'.format(service_id, template_id)
)['data']