From 385a17ca8b116dee6195beb716967b31fb6644da Mon Sep 17 00:00:00 2001 From: karlchillmaid Date: Fri, 10 Sep 2021 15:15:22 +0100 Subject: [PATCH] Add additional instructions for the service name Add additional instructions for the service name - this is more consistent with the local government version of this page Also update tests to use the new content. --- app/templates/views/service-settings/name.html | 4 ++++ tests/app/main/views/test_service_settings.py | 8 ++++++-- 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/app/templates/views/service-settings/name.html b/app/templates/views/service-settings/name.html index b7988a588..ab0d94a3c 100644 --- a/app/templates/views/service-settings/name.html +++ b/app/templates/views/service-settings/name.html @@ -18,6 +18,10 @@ {{ page_header('Change your service name') }} +

Your service name should tell users what the message is about as well as who it’s from.

+ +

You should only use an acronym or initialism if your users are already familiar with it.

+
{% if current_service.prefix_sms %}

Users will see your service name:

diff --git a/tests/app/main/views/test_service_settings.py b/tests/app/main/views/test_service_settings.py index cb413ce71..12b3f2917 100644 --- a/tests/app/main/views/test_service_settings.py +++ b/tests/app/main/views/test_service_settings.py @@ -477,7 +477,9 @@ def test_should_show_service_name( page = client_request.get('main.service_name_change', service_id=SERVICE_ONE_ID) assert page.find('h1').text == 'Change your service name' assert page.find('input', attrs={"type": "text"})['value'] == 'service one' - assert page.select_one('main p').text == 'Users will see your service name:' + assert page.select_one( + 'main p' + ).text == 'Your service name should tell users what the message is about as well as who it’s from.' assert normalize_spaces(page.select_one('main ul').text) == ( 'at the start of every text message ' 'as your email sender name' @@ -533,7 +535,9 @@ def test_should_show_service_name_with_no_prefixing( service_one['prefix_sms'] = False page = client_request.get('main.service_name_change', service_id=SERVICE_ONE_ID) assert page.find('h1').text == 'Change your service name' - assert page.select_one('main p').text == 'Users will see your service name as your email sender name.' + assert page.select_one( + 'main p' + ).text == 'Your service name should tell users what the message is about as well as who it’s from.' def test_should_redirect_after_change_service_name(