darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-08-23 15:57:23 -04:00
Code Issues Packages Projects Releases Wiki Activity

Stop accidental markdown in go live ticket

Browse Source 
In Markdown this is interpreted as a H1:
```
Text
---
```

We can prevent this by adding an extra linebreak, like this:
```
Text

---
```
This commit is contained in:
Chris Hill-Scott
2020-12-22 17:03:22 +00:00
parent 448467435c
commit c3515e44cd
2 changed files with 3 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
app/main/views/service_settings.py
View File

@@ -217,6 +217,7 @@ def submit_request_to_go_live(service_id):
'\nOther live services: {existing_live}' '\nOther live services: {existing_live}'
'\n' '\n'
'\nService reply-to address: {email_reply_to}' '\nService reply-to address: {email_reply_to}'
'\n'
'\n---' '\n---'
'\nRequest sent by {email_address}' '\nRequest sent by {email_address}'
'\n' '\n'

2
tests/app/main/views/test_service_settings.py
View File

@@ -1668,6 +1668,7 @@ def test_should_redirect_after_request_to_go_live(
'Other live services: No\n' 'Other live services: No\n'
'\n' '\n'
'Service reply-to address: test@example.com\n' 'Service reply-to address: test@example.com\n'
'\n'
'---\n' '---\n'
'Request sent by test@user.gov.uk\n' 'Request sent by test@user.gov.uk\n'
).format( ).format(
@@ -1736,6 +1737,7 @@ def test_request_to_go_live_displays_go_live_notes_in_zendesk_ticket(
'Other live services: No\n' 'Other live services: No\n'
'\n' '\n'
'Service reply-to address: test@example.com\n' 'Service reply-to address: test@example.com\n'
'\n'
'---\n' '---\n'
'Request sent by test@user.gov.uk\n' 'Request sent by test@user.gov.uk\n'
).format( ).format(