darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-09-06 22:08:25 -04:00
Code Issues Packages Projects Releases Wiki Activity

Remove redundant fixtures and test setup

Browse Source 
In response to [^1] and [^2].

[^1]: https://github.com/alphagov/notifications-admin/pull/4180/files#r819673624
[^2]: https://github.com/alphagov/notifications-admin/pull/4180/files#r819673799
This commit is contained in:
Ben Thorner
2022-03-07 10:22:52 +00:00
parent 33c6ca0989
commit c22d3412fa
1 changed files with 2 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
tests/app/main/views/test_service_settings.py
View File

@@ -5424,7 +5424,7 @@ def test_get_email_branding_govuk_and_nhs_pages(
assert normalize_spaces(page.select_one('.page-footer button').text) == 'Use this branding' assert normalize_spaces(page.select_one('.page-footer button').text) == 'Use this branding'
def test_get_email_branding_something_else_page(client_request, service_one, mocker): def test_get_email_branding_something_else_page(client_request, service_one):
# expect to have a "NHS" option as well as the # expect to have a "NHS" option as well as the
# fallback, so back button goes to choices page # fallback, so back button goes to choices page
service_one['organisation_type'] = 'nhs_central' service_one['organisation_type'] = 'nhs_central'
@@ -5441,7 +5441,7 @@ def test_get_email_branding_something_else_page(client_request, service_one, moc
) )
def test_get_email_branding_something_else_page_is_only_option(client_request, mocker, service_one): def test_get_email_branding_something_else_page_is_only_option(client_request, service_one):
# should only have a "something else" option # should only have a "something else" option
# so back button goes back to settings page # so back button goes back to settings page
service_one['organisation_type'] = 'other' service_one['organisation_type'] = 'other'
@@ -5741,17 +5741,13 @@ def test_service_settings_links_to_branding_request_page_for_letters(
(False, f'/services/{SERVICE_ONE_ID}/service-settings/email-branding'), (False, f'/services/{SERVICE_ONE_ID}/service-settings/email-branding'),
]) ])
def test_service_settings_links_to_branding_request_page_for_emails( def test_service_settings_links_to_branding_request_page_for_emails(
mocker,
service_one, service_one,
client_request, client_request,
no_reply_to_email_addresses, no_reply_to_email_addresses,
no_letter_contact_blocks,
single_sms_sender, single_sms_sender,
single_branding_option, single_branding_option,
expected_href, expected_href,
): ):
service_one['permissions'].append('letter')
if single_branding_option: if single_branding_option:
# should only have a "something else" option # should only have a "something else" option
# so we go straight to that form # so we go straight to that form