darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-08-25 08:44:23 -04:00
Code Issues Packages Projects Releases Wiki Activity

Clean up test formatting

Browse Source 
Ensures that:
- test name reflects what it now does
- only one parameter per line
- argument order in parameterize matches argument order in function
  definition
This commit is contained in:
Chris Hill-Scott
2020-07-14 10:43:48 +01:00
parent fd05bed600
commit c20958ef34
1 changed files with 12 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
tests/app/main/views/test_service_settings.py
View File

@@ -3677,7 +3677,8 @@ def test_unknown_channel_404s(
'It costs between 35p and 81p to send a letter using Notify.', 'It costs between 35p and 81p to send a letter using Notify.',
'Send letters', 'Send letters',
['email', 'sms'], ['email', 'sms'],
'False', 'True', 'False',
'True',
['email', 'sms', 'letter'], ['email', 'sms', 'letter'],
), ),
( (
@@ -3685,7 +3686,8 @@ def test_unknown_channel_404s(
'It costs between 35p and 81p to send a letter using Notify.', 'It costs between 35p and 81p to send a letter using Notify.',
'Send letters', 'Send letters',
['email', 'sms', 'letter'], ['email', 'sms', 'letter'],
'True', 'False', 'True',
'False',
['email', 'sms'], ['email', 'sms'],
), ),
( (
@@ -3693,7 +3695,8 @@ def test_unknown_channel_404s(
'You have a free allowance of 250,000 text messages each financial year.', 'You have a free allowance of 250,000 text messages each financial year.',
'Send text messages', 'Send text messages',
[], [],
'False', 'True', 'False',
'True',
['sms'], ['sms'],
), ),
( (
@@ -3701,7 +3704,8 @@ def test_unknown_channel_404s(
'It’s free to send emails through GOV.UK Notify.', 'It’s free to send emails through GOV.UK Notify.',
'Send emails', 'Send emails',
[], [],
'False', 'True', 'False',
'True',
['email'], ['email'],
), ),
( (
@@ -3709,11 +3713,12 @@ def test_unknown_channel_404s(
'It’s free to send emails through GOV.UK Notify.', 'It’s free to send emails through GOV.UK Notify.',
'Send emails', 'Send emails',
['email', 'sms', 'letter'], ['email', 'sms', 'letter'],
'True', 'True', 'True',
'True',
['email', 'sms', 'letter'], ['email', 'sms', 'letter'],
), ),
]) ])
def test_switch_service_enable_letters( def test_switch_service_channels_on_and_off(
client_request, client_request,
service_one, service_one,
mocker, mocker,
@@ -3721,9 +3726,9 @@ def test_switch_service_enable_letters(
channel, channel,
expected_first_para, expected_first_para,
expected_legend, expected_legend,
initial_permissions,
expected_initial_value, expected_initial_value,
posted_value, posted_value,
initial_permissions,
expected_updated_permissions, expected_updated_permissions,
): ):
mocked_fn = mocker.patch('app.service_api_client.update_service', return_value=service_one) mocked_fn = mocker.patch('app.service_api_client.update_service', return_value=service_one)