darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-09-09 10:19:48 -04:00
Code Issues Packages Projects Releases Wiki Activity

rename two_factor to two_factor_sms

Browse Source 
it's a bit confusing now that there are three endpoints. the other two
are already renamed two_factor_email and two_factor_webauthn
This commit is contained in:
Leo Hemsted
2021-05-14 19:15:12 +01:00
parent 907a7dc363
commit c203f624ca
12 changed files with 26 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
tests/app/main/views/test_sign_in.py
View File

@@ -130,7 +130,9 @@ def test_process_sms_auth_sign_in_return_2fa_template(
'email_address': email_address,
'password': password})
assert response.status_code == 302
assert response.location == url_for('.two_factor', next=redirect_url, _external=True)
# TODO: remove this assert once we start defaulting to returning two_factor_sms first
assert '/two-factor-sms' not in response.location
assert response.location == url_for('.two_factor_sms', next=redirect_url, _external=True)
mock_verify_password.assert_called_with(api_user_active['id'], password)
mock_get_user_by_email.assert_called_with('valid@example.gov.uk')