mirror of
https://github.com/GSA/notifications-admin.git
synced 2026-09-09 17:09:49 -04:00
404 for step-0
This commit is contained in:
@@ -46,7 +46,7 @@ def begin_tour(service_id, template_id):
|
|||||||
def tour_step(service_id, template_id, step_index):
|
def tour_step(service_id, template_id, step_index):
|
||||||
db_template = current_service.get_template_with_user_permission_or_403(template_id, current_user)
|
db_template = current_service.get_template_with_user_permission_or_403(template_id, current_user)
|
||||||
|
|
||||||
if db_template['template_type'] != 'sms':
|
if (db_template['template_type'] != 'sms' or step_index == 0):
|
||||||
abort(404)
|
abort(404)
|
||||||
|
|
||||||
if 'placeholders' not in session:
|
if 'placeholders' not in session:
|
||||||
|
|||||||
@@ -206,6 +206,24 @@ def test_should_404_if_non_sms_template_for_tour_step(
|
|||||||
)
|
)
|
||||||
|
|
||||||
|
|
||||||
|
def test_should_404_for_get_tour_step_0(
|
||||||
|
client_request,
|
||||||
|
mock_get_service_template_with_multiple_placeholders,
|
||||||
|
service_one,
|
||||||
|
fake_uuid,
|
||||||
|
):
|
||||||
|
with client_request.session_transaction() as session:
|
||||||
|
session['placeholders'] = {}
|
||||||
|
|
||||||
|
client_request.get(
|
||||||
|
'main.tour_step',
|
||||||
|
service_id=SERVICE_ONE_ID,
|
||||||
|
template_id=fake_uuid,
|
||||||
|
step_index=0,
|
||||||
|
_expected_status=404
|
||||||
|
)
|
||||||
|
|
||||||
|
|
||||||
@pytest.mark.parametrize('method', ['GET', 'POST'])
|
@pytest.mark.parametrize('method', ['GET', 'POST'])
|
||||||
def test_should_403_if_user_does_not_have_send_permissions_for_tour_step(
|
def test_should_403_if_user_does_not_have_send_permissions_for_tour_step(
|
||||||
mocker,
|
mocker,
|
||||||
|
|||||||
Reference in New Issue
Block a user