From c05502835b0201f1856b61871dab5e1f10fdd17b Mon Sep 17 00:00:00 2001
From: Ben Thorner <ben.thorner@digital.cabinet-office.gov.uk>
Date: Tue, 3 May 2022 13:01:06 +0100
Subject: [PATCH] Simplify monthly letter breakdown ordering test

This doesn't need to test variable rates for every postage class,
which is more an aspect of grouping. It only needs to check that
some out-of-order usage gets reordered appropriately.
---
 tests/app/main/views/test_dashboard.py | 84 +++-----------------------
 1 file changed, 9 insertions(+), 75 deletions(-)

diff --git a/tests/app/main/views/test_dashboard.py b/tests/app/main/views/test_dashboard.py
index a6b5a0e5e..9d28284ae 100644
--- a/tests/app/main/views/test_dashboard.py
+++ b/tests/app/main/views/test_dashboard.py
@@ -1093,87 +1093,21 @@ def test_usage_page_monthly_breakdown(
     assert '1,230 text messages at 1.70p' in monthly_breakdown
 
 
-@freeze_time("2012-04-30 12:12:12")
-def test_usage_page_displays_letters_ordered_by_postage(
-    mocker,
+@freeze_time("2012-03-31 12:12:12")
+def test_usage_page_letter_breakdown_ordering(
     client_request,
     service_one,
+    mock_get_monthly_usage_for_service,
     mock_get_annual_usage_for_service,
     mock_get_free_sms_fragment_limit
 ):
-    monthly_usage = [
-        {
-            'month': 'April',
-            'notification_type': 'letter',
-            'rate': 0.5,
-            'chargeable_units': 1,
-            'notifications_sent': 1,
-            'postage': 'second',
-            'letter_cost': 0.5,
-        },
-        {
-            'month': 'April',
-            'notification_type': 'letter',
-            'rate': 1,
-            'chargeable_units': 1,
-            'notifications_sent': 1,
-            'postage': 'europe',
-            'letter_cost': 1,
-        },
-        {
-            'month': 'April',
-            'notification_type': 'letter',
-            'rate': 1,
-            'chargeable_units': 2,
-            'notifications_sent': 2,
-            'postage': 'rest-of-word',
-            'letter_cost': 2,
-        },
-        {
-            'month': 'April',
-            'notification_type': 'letter',
-            'rate': 1.5,
-            'chargeable_units': 7,
-            'notifications_sent': 7,
-            'postage': 'europe',
-            'letter_cost': 11.5,
-        },
-        {
-            'month': 'April',
-            'notification_type': 'letter',
-            'rate': 0.3,
-            'chargeable_units': 3,
-            'notifications_sent': 3,
-            'postage': 'second',
-            'letter_cost': 0.9,
-        },
-        {
-            'month': 'April',
-            'notification_type': 'letter',
-            'rate': 0.5,
-            'chargeable_units': 1,
-            'notifications_sent': 1,
-            'postage': 'first',
-            'letter_cost': 0.5,
-        },
-    ]
+    page = client_request.get('main.usage', service_id=SERVICE_ONE_ID)
+    row_for_feb = page.find('table').find_all('tr', class_='table-row')[10]
+    postage_details = row_for_feb.find_all('li', class_='tabular-numbers')
 
-    mocker.patch('app.billing_api_client.get_monthly_usage_for_service', return_value=monthly_usage)
-    service_one['permissions'].append('letter')
-    page = client_request.get(
-        'main.usage',
-        service_id=SERVICE_ONE_ID,
-    )
-
-    row_for_april = page.find('table').find('tr', class_='table-row')
-    postage_details = row_for_april.find_all('li', class_='tabular-numbers')
-
-    assert len(postage_details) == 5
-    assert normalize_spaces(postage_details[0].text) == '1 first class letter at 50p'
-    assert normalize_spaces(postage_details[1].text) == '3 second class letters at 30p'
-    assert normalize_spaces(postage_details[2].text) == '1 second class letter at 50p'
-    assert normalize_spaces(postage_details[3].text) == '3 international letters at £1.00'
-    assert normalize_spaces(postage_details[4].text) == '7 international letters at £1.50'
+    assert normalize_spaces(postage_details[2].text) == '5 first class letters at 33p'
+    assert normalize_spaces(postage_details[3].text) == '10 second class letters at 31p'
+    assert normalize_spaces(postage_details[4].text) == '10 international letters at 84p'
 
 
 def test_usage_page_with_0_free_allowance(