darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-08-20 22:40:31 -04:00
Code Issues Packages Projects Releases Wiki Activity

Base ‘% complete’ on notifications requested

Browse Source 
The job is complete when all notifications are delivered or failed.

The report is complete once we have all notifications are in the
database.

This commit changes the meaning of the percentage from the former to the
latter. This is how it was before we removed the aggregate stats for
jobs.
This commit is contained in:
Chris Hill-Scott
2016-08-30 15:13:37 +01:00
parent 37a1eb22b0
commit bf872ab342
3 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
tests/conftest.py
View File

@@ -864,7 +864,7 @@ def mock_get_job_in_progress(mocker, api_user_active):
return {"data": job_json(
service_id, api_user_active, job_id=job_id,
notification_count=10,
notifications_sent=5
notifications_requested=5
)}
return mocker.patch('app.job_api_client.get_job', side_effect=_get_job)