mirror of
https://github.com/GSA/notifications-admin.git
synced 2026-08-11 09:28:27 -04:00
Bump gulp-sass
Intended to deal with this security vulnerability: https://github.blog/2021-09-08-github-security-update-vulnerabilities-tar-npmcli-arborist/ Bumping gulp-sass to version 5 removes its dependency on the tar package mentioned in that article. Version 5 requires you to specify a compiler directly in the gulpfile so that code is changed in line with this guidance: https://github.com/dlmanning/gulp-sass/tree/master#migrating-to-version-5 Note: node-sass is now deprecated so this also changes the sass compiler gulp-sass uses to dart-sass (aka 'sass'), the compiler now recommended by the Sass project: https://sass-lang.com/dart-sass This also bumps gulp and all its plugin modules to their latest versions, for parity.
This commit is contained in:
@@ -20,7 +20,7 @@ plugins.cssUrlAdjuster = require('gulp-css-url-adjuster');
|
||||
plugins.jshint = require('gulp-jshint');
|
||||
plugins.prettyerror = require('gulp-prettyerror');
|
||||
plugins.rollup = require('gulp-better-rollup')
|
||||
plugins.sass = require('gulp-sass');
|
||||
plugins.sass = require('gulp-sass')(require('sass'));
|
||||
plugins.sassLint = require('gulp-sass-lint');
|
||||
plugins.uglify = require('gulp-uglify');
|
||||
|
||||
@@ -207,8 +207,7 @@ const sass = () => {
|
||||
paths.src + '/stylesheets/print.scss'
|
||||
])
|
||||
.pipe(plugins.prettyerror())
|
||||
.pipe(plugins.sass({
|
||||
outputStyle: 'nested',
|
||||
.pipe(plugins.sass.sync({
|
||||
includePaths: [
|
||||
paths.npm + 'govuk-elements-sass/public/sass/',
|
||||
paths.toolkit + 'stylesheets/',
|
||||
|
||||
Reference in New Issue
Block a user