darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-05-05 08:31:00 -04:00
Code Issues Packages Projects Releases Wiki Activity

make add_rate_to_jobs singular

Browse Source 
there was no reason for it to operate on a whole list at a time
This commit is contained in:
Leo Hemsted
2016-10-05 09:52:31 +01:00
parent 549a17c1f7
commit be97edce7f
3 changed files with 26 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

31
tests/app/test_statistics_utils.py
View File

@@ -1,6 +1,6 @@
import pytest
from app.statistics_utils import sum_of_statistics, add_rates_to, add_rate_to_jobs, statistics_by_state
from app.statistics_utils import sum_of_statistics, add_rates_to, add_rate_to_job, statistics_by_state
@pytest.mark.parametrize('delivery_statistics', [
@@ -118,20 +118,29 @@ def test_service_statistics_by_state():
@pytest.mark.parametrize('failed, delivered, expected_failure_rate', [
(0, 0, 0),
(0, 1, 0),
(1, 1, 50),
(1, 0, 100),
(1, 4, 20)
])
def test_add_rate_to_jobs(failed, delivered, expected_failure_rate):
resp = add_rate_to_jobs([
def test_add_rate_to_job_calculates_rate(failed, delivered, expected_failure_rate):
resp = add_rate_to_job(
{
'notifications_failed': failed,
'notifications_delivered': delivered
},
{
'notifications_failed': 1,
'notifications_delivered': 1
'notifications_delivered': delivered,
'id': 'foo'
}
])
)
assert resp[0]['failure_rate'] == expected_failure_rate
assert resp[1]['failure_rate'] == 50
assert resp['failure_rate'] == expected_failure_rate
def test_add_rate_to_job_preserves_initial_fields():
resp = add_rate_to_job(
{
'notifications_failed': 0,
'notifications_delivered': 0,
'id': 'foo'
}
)
assert set(resp.keys()) == {'notifications_failed', 'notifications_delivered', 'id', 'failure_rate'}