darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-08-23 15:57:23 -04:00
Code Issues Packages Projects Releases Wiki Activity

Change list items on /users page

Browse Source 
Change the HTML & CSS for user-list-item's to
support their content being split into 2 columns
of a grid instead of the edit link being
positioned absolutely.

Also includes:
1. removes `<div>`s from `<ul>` (non-valid HTML)
2. split action link out from permissions list
3. split summary of folder permissions out from
   permissions list
4. introduces a class for blocks of text that
   appear when there are no items.
5. fixes tests broken by changes to HTML
This commit is contained in:
Tom Byers
2020-08-19 14:52:17 +01:00
parent 3bebb1fbfd
commit be83ea36ea
4 changed files with 95 additions and 80 deletions
Download Patch File Download Diff File Expand all files Collapse all files

36
app/assets/stylesheets/components/tick-cross.scss
View File

@@ -36,44 +36,10 @@
}
&-edit-link {
text-align: right;
position: absolute;
top: -25px;
right: -135px;
a {
&:before {
content: "";
display: block;
position: absolute;
top: -1 * govuk-spacing(3) - 1;
right: 0;
bottom: -1 * govuk-spacing(3);
left: -1 * govuk-spacing(3);
background: transparent;
}
&:active:before,
&:focus:before {
border-color: $yellow;
border-style: solid;
border-width: 15px 3px 15px 15px;
right: -3px;
}
}
}
&-hint {
color: #6F777B;
padding-top: 5px;
margin: 0;
}
}

59
app/assets/stylesheets/views/users.scss
View File

@@ -7,9 +7,8 @@ $item-top-padding: govuk-spacing(3);
&-item {
padding: $item-top-padding 150px govuk-spacing(3) 0;
padding: govuk-spacing(3) 0px;
border-top: 1px solid $border-colour;
position: relative;
&-heading {
@@ -29,13 +28,61 @@ $item-top-padding: govuk-spacing(3);
border-bottom: 1px solid $border-colour;
}
& :last-child {
margin-bottom: 0;
}
&-blank {
margin-bottom: govuk-spacing(3);
@include govuk-media-query($from: tablet) {
margin-bottom: 0;
}
}
}
&-edit-link {
text-align: right;
position: absolute;
top: $item-top-padding;
right: 0px;
position: relative;
display: block;
margin: govuk-spacing(3) 0 govuk-spacing(3);
@include govuk-media-query($from: tablet) {
float: right;
margin: 0;
}
&:before {
content: "";
display: block;
position: absolute;
top: -1 * govuk-spacing(3) - 1;
right: 0;
bottom: -1 * govuk-spacing(3);
left: -1 * govuk-spacing(3);
background: transparent;
}
&:active:before,
&:focus:before {
border-color: $yellow;
border-style: solid;
border-width: 15px 3px;
right: -3px;
left: -3px;
@include govuk-media-query($from: tablet) {
border-width: 15px 3px 15px 15px;
left: -15px;
}
}
}
}