darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-08-16 20:49:00 -04:00
Code Issues Packages Projects Releases Wiki Activity

Consolidate callback forms and convert them to gov uk frontend

Browse Source 
We had two identical callback form classes. One for delivery callbacks
and one for inbound sms callbacks. Since they did not differ I consolidated
them into one CallbackForm class that they both inherited from previously.

I also substituted field classes for this form with new fields
that cooperate with gov uk frontend.
This commit is contained in:
Pea Tyczynska
2020-08-03 15:10:02 +01:00
committed by Tom Byers
parent 6f1fc3d16d
commit be7d4891ae
5 changed files with 36 additions and 63 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
tests/app/main/views/test_api_integration.py
View File

@@ -512,9 +512,9 @@ def test_callback_forms_validation(
_data=data,
_expected_status=200
)
error_msgs = ' '.join(msg.text.strip() for msg in response.select(".error-message"))
error_msgs = ' '.join(msg.text.strip() for msg in response.select(".govuk-error-message"))
assert error_msgs == expected_errors
assert expected_errors in error_msgs
@pytest.mark.parametrize('bearer_token', ['', 'some-bearer-token'])