Remove template link from preview for precompiled letters

This commit is contained in:
Ken Tsang
2018-03-02 17:06:51 +00:00
parent 5c26d7a061
commit bcf86239c6
5 changed files with 49 additions and 4 deletions

View File

@@ -205,6 +205,7 @@ def template_json(service_id,
service_letter_contact=None,
reply_to=None,
reply_to_text=None,
is_precompiled_letter=False,
):
template = {
'id': id_,
@@ -219,6 +220,7 @@ def template_json(service_id,
'service_letter_contact': service_letter_contact,
'reply_to': reply_to,
'reply_to_text': reply_to_text,
'is_precompiled_letter': is_precompiled_letter,
}
if content is None:
template['content'] = "template content"

View File

@@ -277,3 +277,37 @@ def test_notification_page_has_link_to_download_letter(
download_link = None
assert download_link == expected_link(notification_id=fake_uuid)
@pytest.mark.parametrize('is_precompiled_letter, has_template_link', [
(True, False),
(False, True),
])
def test_notification_page_has_expected_template_link_for_letter(
client_request,
mocker,
fake_uuid,
service_one,
is_precompiled_letter,
has_template_link
):
mock_get_notification(
mocker, fake_uuid, template_type='letter', is_precompiled_letter=is_precompiled_letter)
mocker.patch(
'app.main.views.notifications.get_page_count_for_letter',
return_value=1
)
page = client_request.get(
'main.view_notification',
service_id=SERVICE_ONE_ID,
notification_id=fake_uuid,
)
link = page.select_one('main > p:nth-of-type(1) > a')
if has_template_link:
assert link
else:
assert link is None

View File

@@ -2404,6 +2404,8 @@ def mock_get_notification(
notification_status='delivered',
redact_personalisation=False,
template_type=None,
template_name='sample template',
is_precompiled_letter=False
):
def _get_notification(
service_id,
@@ -2430,6 +2432,8 @@ def mock_get_notification(
subject='blah',
redact_personalisation=redact_personalisation,
type_=template_type,
is_precompiled_letter=is_precompiled_letter,
name=template_name
)
return noti