darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-07-21 08:29:27 -04:00
Code Issues Packages Projects Releases Wiki Activity

Refactored code for new service permissions

Browse Source
This commit is contained in:
Ken Tsang
2017-06-23 13:35:08 +01:00
parent f8a3132d8b
commit bcc45ede9c
14 changed files with 74 additions and 66 deletions
Download Patch File Download Diff File Expand all files Collapse all files

33
tests/app/main/views/test_letters.py
View File

@@ -11,22 +11,24 @@ letters_urls = [
@pytest.mark.parametrize('url', letters_urls)
@pytest.mark.parametrize('can_send_letters, response_code', [
(True, 200),
(False, 403)
@pytest.mark.parametrize('permissions, response_code', [
(['letter'], 200),
([], 403)
])
def test_letters_access_restricted(
logged_in_platform_admin_client,
mocker,
can_send_letters,
permissions,
response_code,
mock_get_service_templates,
url,
service_one,
):
service = service_json(can_send_letters=can_send_letters)
mocker.patch('app.service_api_client.get_service', return_value={"data": service})
service_one['permissions'] = permissions
response = logged_in_platform_admin_client.get(url(service_id=service['id']))
mocker.patch('app.service_api_client.get_service', return_value={"data": service_one})
response = logged_in_platform_admin_client.get(url(service_id=service_one['id']))
assert response.status_code == response_code
@@ -40,29 +42,30 @@ def test_letters_lets_in_without_permission(
api_user_active,
mock_get_service_templates,
url,
service_one
):
service = service_json(can_send_letters=True)
mocker.patch('app.service_api_client.get_service', return_value={"data": service})
service_one['permissions'] = ['letter']
mocker.patch('app.service_api_client.get_service', return_value={"data": service_one})
client.login(api_user_active)
response = client.get(url(service_id=service['id']))
response = client.get(url(service_id=service_one['id']))
assert api_user_active.permissions == {}
assert response.status_code == 200
@pytest.mark.parametrize('can_send_letters, choices', [
(True, ['Email', 'Text message', 'Letter']),
(False, ['Email', 'Text message'])
@pytest.mark.parametrize('permissions, choices', [
(['email', 'sms', 'letter'], ['Email', 'Text message', 'Letter']),
(['email', 'sms'], ['Email', 'Text message'])
])
def test_given_option_to_add_letters_if_allowed(
logged_in_client,
service_one,
mocker,
can_send_letters,
permissions,
choices,
):
service_one['can_send_letters'] = can_send_letters
service_one['permissions'] = permissions
mocker.patch('app.service_api_client.get_service', return_value={"data": service_one})
response = logged_in_client.get(url_for('main.add_template_by_type', service_id=service_one['id']))