darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-07-02 23:47:42 -04:00
Code Issues Packages Projects Releases Wiki Activity

Refactored code for new service permissions

Browse Source
This commit is contained in:
Ken Tsang
2017-06-23 13:35:08 +01:00
parent f8a3132d8b
commit bcc45ede9c
14 changed files with 74 additions and 66 deletions
Download Patch File Download Diff File Expand all files Collapse all files

25
app/main/views/service_settings.py
View File

@@ -208,14 +208,24 @@ def service_switch_research_mode(service_id):
return redirect(url_for('.service_settings', service_id=service_id))
def switch_service_permissions(service_id, permission):
permissions = current_service['permissions'].copy()
if permission in permissions:
permissions.remove(permission)
else:
permissions.append(permission)
service_api_client.update_service_with_properties(
service_id,
{'permissions': permissions}
)
@main.route("/services/<service_id>/service-settings/can-send-letters")
@login_required
@user_has_permissions(admin_override=True)
def service_switch_can_send_letters(service_id):
service_api_client.update_service_with_properties(
service_id,
{"can_send_letters": not current_service['can_send_letters']}
)
switch_service_permissions(service_id, 'letter')
return redirect(url_for('.service_settings', service_id=service_id))
@@ -223,10 +233,7 @@ def service_switch_can_send_letters(service_id):
@login_required
@user_has_permissions(admin_override=True)
def service_switch_can_send_international_sms(service_id):
service_api_client.update_service_with_properties(
service_id,
{"can_send_international_sms": not current_service['can_send_international_sms']}
)
switch_service_permissions(service_id, 'international_sms')
return redirect(url_for('.service_settings', service_id=service_id))
@@ -350,7 +357,7 @@ def service_set_letters(service_id):
@user_has_permissions('manage_settings', admin_override=True)
def service_set_letter_contact_block(service_id):
if not current_service['can_send_letters']:
if 'letter' not in current_service['permissions']:
abort(403)
form = ServiceLetterContactBlock(letter_contact_block=current_service['letter_contact_block'])