darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-08-23 07:46:23 -04:00
Code Issues Packages Projects Releases Wiki Activity

Replace $gutter with govuk-spacing function

Browse Source 
Replaced `$gutter` and similar variables such as `$gutter-half` with the
`govuk-spacing()` static spacing function. This uses `govuk-spacing()`
instead of `$govuk-gutter` because `$govuk-gutter` should only be used
for the gaps in between grid columns and we were mostly using `$gutter`
to add more space around elements.

There are other places in the SCSS files where we had hardcoded a
measurement in px which could be replaced with `govuk-spacing`, but this
commit only replaces the existing uses of `$gutter`.
This commit is contained in:
Katie Smith
2020-02-21 13:21:44 +00:00
parent a85f7fa2c1
commit bc83ff6c09
35 changed files with 139 additions and 139 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
app/assets/stylesheets/components/navigation.scss
View File

@@ -1,7 +1,7 @@
.navigation {
@include govuk-font($size: 19);
padding: 0 $gutter 0 0;
padding: 0 govuk-spacing(6) 0 0;
$padding-top: 14px;
$padding-bottom: 11px;
@@ -53,7 +53,7 @@
position: absolute;
top: 0;
right: 0;
padding: $padding-top 0 $padding-bottom $gutter-half;
padding: $padding-top 0 $padding-bottom govuk-spacing(3);
&:focus {
outline: none;
@@ -67,7 +67,7 @@
&-back-to {
padding: $padding-top $gutter-half $padding-bottom 0;
padding: $padding-top govuk-spacing(3) $padding-bottom 0;
display: inline-block;
}
@@ -145,7 +145,7 @@
// https://github.com/alphagov/product-page-example/blob/master/source/stylesheets/modules/_sub-navigation.scss
.sub-navigation {
@include media(tablet) {
margin-top: $gutter * 1.5;
margin-top: govuk-spacing(6) * 1.5;
}
ol,
@@ -160,7 +160,7 @@
border-bottom: 1px $grey-3 solid;
display: block;
padding: $gutter-one-third 0;
padding: govuk-spacing(2) 0;
a:link {
text-decoration: none;
@@ -172,7 +172,7 @@
}
ol ol & {
padding-left: $gutter;
padding-left: govuk-spacing(6);
}
}