darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-08-24 00:07:02 -04:00
Code Issues Packages Projects Releases Wiki Activity

Replace $gutter with govuk-spacing function

Browse Source 
Replaced `$gutter` and similar variables such as `$gutter-half` with the
`govuk-spacing()` static spacing function. This uses `govuk-spacing()`
instead of `$govuk-gutter` because `$govuk-gutter` should only be used
for the gaps in between grid columns and we were mostly using `$gutter`
to add more space around elements.

There are other places in the SCSS files where we had hardcoded a
measurement in px which could be replaced with `govuk-spacing`, but this
commit only replaces the existing uses of `$gutter`.
This commit is contained in:
Katie Smith
2020-02-21 13:21:44 +00:00
parent a85f7fa2c1
commit bc83ff6c09
35 changed files with 139 additions and 139 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
app/assets/stylesheets/components/message.scss
View File

@@ -2,7 +2,7 @@
display: inline-block;
vertical-align: top;
width: 20px;
height: $gutter;
height: govuk-spacing(6);
position: relative;
&:before {
@@ -31,8 +31,8 @@
margin: 0;
a {
margin-bottom: -$gutter;
padding-bottom: $gutter;
margin-bottom: -govuk-spacing(6);
padding-bottom: govuk-spacing(6);
&:hover .message-name-separator:before {
border-color: $link-hover-colour;
@@ -64,7 +64,7 @@
&-type {
color: $secondary-text-colour;
margin: 0 0 $gutter-two-thirds 0;
margin: 0 0 govuk-spacing(4) 0;
pointer-events: none;
}
@@ -72,7 +72,7 @@
#template-list {
margin-top: $gutter;
margin-top: govuk-spacing(6);
&.top-gutter-5px {
margin-top: 5px;
@@ -87,7 +87,7 @@
&-with-checkbox {
position: relative;
padding-left: $gutter * 2;
padding-left: govuk-spacing(9);
.multiple-choice {
position: absolute;
@@ -148,22 +148,22 @@
&-empty {
color: $secondary-text-colour;
padding: $gutter-half 0 $gutter-one-third 0;
padding: govuk-spacing(3) 0 govuk-spacing(2) 0;
}
&-selected-counter {
color: $secondary-text-colour;
margin: $gutter-half 0;
margin: govuk-spacing(3) 0;
@include media(tablet) {
position: absolute;
right: 0;
top: $gutter - 1px;
top: govuk-spacing(6) - 1px;
margin: 0;
}
.content-fixed & {
right: $gutter-half;
right: govuk-spacing(3);
}
}
@@ -173,7 +173,7 @@
.folder-heading {
.govuk-grid-row & {
margin: $gutter-half 0 20px 0;
margin: govuk-spacing(3) 0 20px 0;
word-wrap: break-word;
}
@@ -246,7 +246,7 @@
&-manage-link {
display: block;
text-align: right;
padding: $gutter-two-thirds 0 0 0;
padding: govuk-spacing(4) 0 0 0;
position: relative;
top: -6px;
}