darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-09-05 15:58:25 -04:00
Code Issues Packages Projects Releases Wiki Activity

Replace $gutter with govuk-spacing function

Browse Source 
Replaced `$gutter` and similar variables such as `$gutter-half` with the
`govuk-spacing()` static spacing function. This uses `govuk-spacing()`
instead of `$govuk-gutter` because `$govuk-gutter` should only be used
for the gaps in between grid columns and we were mostly using `$gutter`
to add more space around elements.

There are other places in the SCSS files where we had hardcoded a
measurement in px which could be replaced with `govuk-spacing`, but this
commit only replaces the existing uses of `$gutter`.
This commit is contained in:
Katie Smith
2020-02-21 13:21:44 +00:00
parent a85f7fa2c1
commit bc83ff6c09
35 changed files with 139 additions and 139 deletions
Download Patch File Download Diff File Expand all files Collapse all files

28
app/assets/stylesheets/_grids.scss
View File

@@ -23,28 +23,28 @@
.top-gutter {
@extend %contain-floats;
display: block;
margin-top: $gutter;
margin-top: govuk-spacing(6);
clear: both;
}
.top-gutter-4-3 {
@extend %top-gutter;
margin-top: $gutter * 4 / 3;
margin-top: govuk-spacing(7);
}
.top-gutter-1-2 {
@extend %top-gutter;
margin-top: $gutter-half;
margin-top: govuk-spacing(3);
}
.top-gutter-1-3 {
@extend %top-gutter;
margin-top: $gutter / 3;
margin-top: govuk-spacing(2);
}
.top-gutter-2-3 {
@extend %top-gutter;
margin-top: $gutter * 2 / 3;
margin-top: govuk-spacing(4);
}
.top-gutter-0 {
@@ -54,41 +54,41 @@
%bottom-gutter,
.bottom-gutter {
@extend %contain-floats;
margin-bottom: $gutter;
margin-bottom: govuk-spacing(6);
clear: both;
}
.bottom-gutter-2-3 {
@extend %bottom-gutter;
margin-bottom: $gutter-two-thirds;
margin-bottom: govuk-spacing(4);
}
.bottom-gutter-1-2 {
@extend %bottom-gutter;
margin-bottom: $gutter-half;
margin-bottom: govuk-spacing(3);
}
.bottom-gutter-1-3 {
@extend %bottom-gutter;
margin-bottom: $gutter/3;
margin-bottom: govuk-spacing(2);
}
.bottom-gutter-3-2 {
@extend %bottom-gutter;
margin-bottom: $gutter * 3/2;
margin-bottom: govuk-spacing(6) * 3/2;
}
.bottom-gutter-2 {
@extend %bottom-gutter;
margin-bottom: $gutter * 2;
margin-bottom: govuk-spacing(9);
}
.left-gutter {
padding-left: $gutter;
padding-left: govuk-spacing(6);
}
.left-gutter-4-3 {
padding-left: $gutter * 4 / 3;
padding-left: govuk-spacing(7);
}
.align-with-heading {
@@ -111,5 +111,5 @@
}
.align-with-big-number-hint {
margin-top: $gutter / 0.6;
margin-top: govuk-spacing(8);
}