Use named arguments for clearer string formatting

Helps when the string is long.

Also helps disambiguate between the CDN domain used for the logos and
those for CSS/JS.
This commit is contained in:
Chris Hill-Scott
2018-11-29 11:41:13 +00:00
parent fe6610c221
commit bc6b9c7af7
7 changed files with 20 additions and 23 deletions

View File

@@ -54,7 +54,7 @@ from app.main.forms import (
from app.utils import (
AgreementInfo,
email_safe,
get_cdn_domain,
get_logo_cdn_domain,
user_has_permissions,
user_is_platform_admin,
)
@@ -991,7 +991,7 @@ def get_branding_as_value_and_label(email_branding):
def get_branding_as_dict(email_branding):
return {
branding['id']: {
'logo': 'https://{}/{}'.format(get_cdn_domain(), branding['logo']),
'logo': 'https://{}/{}'.format(get_logo_cdn_domain(), branding['logo']),
'colour': branding['colour']
} for branding in email_branding
}