darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-09-04 17:48:26 -04:00
Code Issues Packages Projects Releases Wiki Activity

Use named arguments for clearer string formatting

Browse Source 
Helps when the string is long.

Also helps disambiguate between the CDN domain used for the logos and
those for CSS/JS.
This commit is contained in:
Chris Hill-Scott
2018-11-29 11:41:13 +00:00
parent fe6610c221
commit bc6b9c7af7
7 changed files with 20 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
app/main/views/index.py
View File

@@ -16,7 +16,7 @@ from app import email_branding_client
from app.main import main
from app.main.forms import SearchTemplatesForm
from app.main.views.sub_navigation_dictionaries import features_nav
from app.utils import AgreementInfo, get_cdn_domain
from app.utils import AgreementInfo, get_logo_cdn_domain
@main.route('/')
@@ -108,7 +108,7 @@ def email_template():
colour = email_branding['colour']
brand_name = email_branding['text']
brand_colour = colour
brand_logo = ('https://{}/{}'.format(get_cdn_domain(), email_branding['logo'])
brand_logo = ('https://{}/{}'.format(get_logo_cdn_domain(), email_branding['logo'])
if email_branding['logo'] else None)
govuk_banner = branding_type in ['govuk', 'both']
brand_banner = branding_type == 'org_banner'