diff --git a/app/main/views/dashboard.py b/app/main/views/dashboard.py index 380d54852..d3f725761 100644 --- a/app/main/views/dashboard.py +++ b/app/main/views/dashboard.py @@ -57,6 +57,7 @@ def service_dashboard(service_id): @main.route("/services//dashboard.json") @login_required +@user_has_permissions('view_activity', admin_override=True) def service_dashboard_updates(service_id): return jsonify(**{ 'today': render_template( diff --git a/app/notify_client/statistics_api_client.py b/app/notify_client/statistics_api_client.py index 3d4292c36..3492d7e91 100644 --- a/app/notify_client/statistics_api_client.py +++ b/app/notify_client/statistics_api_client.py @@ -18,4 +18,5 @@ class StatisticsApiClient(BaseAPIClient): params['limit_days'] = limit_days return self.get( url='/service/{}/notifications-statistics'.format(service_id), + params=params ) diff --git a/app/templates/components/big-number.html b/app/templates/components/big-number.html index 1b608e7e9..6127c0564 100644 --- a/app/templates/components/big-number.html +++ b/app/templates/components/big-number.html @@ -1,6 +1,10 @@ {% macro big_number(number, label) %} -
- {{ number }} +
+ {% if number is number %} + {{ "{:,}".format(number) }} + {% else %} + {{ number }} + {% endif %} {{ label }}
{% endmacro %} @@ -13,10 +17,10 @@ {% if failures %} {% if failure_link %} - {{ failures }} failed – {{ failure_percentage }}% + {{ "{:,}".format(failures) }} failed – {{ failure_percentage }}% {% else %} - {{ failures }} failed – {{ failure_percentage }}% + {{ "{:,}".format(failures) }} failed – {{ failure_percentage }}% {% endif %} {% else %} No failures diff --git a/tests/app/main/notify_client/test_statistics_client.py b/tests/app/main/notify_client/test_statistics_client.py index a4bcba8ce..70a83f795 100644 --- a/tests/app/main/notify_client/test_statistics_client.py +++ b/tests/app/main/notify_client/test_statistics_client.py @@ -14,4 +14,18 @@ def test_notifications_statistics_client_calls_correct_api_endpoint(mocker, api_ client.get_statistics_for_service(some_service_id) - mock_get.assert_called_once_with(url=expected_url) + mock_get.assert_called_once_with(url=expected_url, params={}) + + +def test_notifications_statistics_client_calls_correct_api_endpoint_with_params(mocker, api_user_active): + + some_service_id = uuid.uuid4() + expected_url = '/service/{}/notifications-statistics'.format(some_service_id) + + client = StatisticsApiClient() + + mock_get = mocker.patch('app.notify_client.statistics_api_client.StatisticsApiClient.get') + + client.get_statistics_for_service(some_service_id, limit_days=99) + + mock_get.assert_called_once_with(url=expected_url, params={'limit_days': 99})