darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-08-24 00:07:02 -04:00
Code Issues Packages Projects Releases Wiki Activity

Add audit event for suspending a service

Browse Source 
This is particularly important for broadcast services, where a rogue
service or platform admin could launch a DoS attack by suspending a
service at a critical moment when it needs to send alerts.
This commit is contained in:
Ben Thorner
2021-07-08 15:20:24 +01:00
parent e72a260e13
commit bb4c86008a
4 changed files with 40 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
tests/app/main/views/test_service_settings.py
View File

@@ -4203,17 +4203,20 @@ def test_cant_archive_inactive_service(
def test_suspend_service_after_confirm(
platform_admin_client,
api_user_active,
service_one,
mocker,
mock_get_inbound_number_for_service,
):
mocked_fn = mocker.patch('app.service_api_client.post', return_value=service_one)
mock_api = mocker.patch('app.service_api_client.post', return_value=service_one)
mock_event = mocker.patch('app.main.views.service_settings.create_suspend_service_event')
response = platform_admin_client.post(url_for('main.suspend_service', service_id=service_one['id']))
assert response.status_code == 302
assert response.location == url_for('main.service_settings', service_id=service_one['id'], _external=True)
assert mocked_fn.call_args == call('/service/{}/suspend'.format(service_one['id']), data=None)
mock_api.assert_called_once_with('/service/{}/suspend'.format(service_one['id']), data=None)
mock_event.assert_called_once_with(service_one['id'], suspended_by_id=api_user_active['id'])
def test_suspend_service_prompts_user(