darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-09-09 16:49:49 -04:00
Code Issues Packages Projects Releases Wiki Activity

Add validation-failed status to FAILURE_STATUSES in admin utils

Browse Source
This commit is contained in:
Pea Tyczynska
2019-01-10 15:54:31 +00:00
parent 2dec697dc9
commit bb1e9d2a0f
3 changed files with 12 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
app/utils.py
View File

@@ -40,7 +40,7 @@ from werkzeug.datastructures import MultiDict
SENDING_STATUSES = ['created', 'pending', 'sending', 'pending-virus-check'] SENDING_STATUSES = ['created', 'pending', 'sending', 'pending-virus-check']
DELIVERED_STATUSES = ['delivered', 'sent', 'returned-letter'] DELIVERED_STATUSES = ['delivered', 'sent', 'returned-letter']
FAILURE_STATUSES = ['failed', 'temporary-failure', 'permanent-failure', FAILURE_STATUSES = ['failed', 'temporary-failure', 'permanent-failure',
'technical-failure', 'virus-scan-failed'] 'technical-failure', 'virus-scan-failed', 'validation-failed']
REQUESTED_STATUSES = SENDING_STATUSES + DELIVERED_STATUSES + FAILURE_STATUSES REQUESTED_STATUSES = SENDING_STATUSES + DELIVERED_STATUSES + FAILURE_STATUSES

7
tests/app/main/views/test_activity.py
View File

@@ -53,7 +53,7 @@ from tests.conftest import (
'created', 'pending', 'sending', 'pending-virus-check', 'created', 'pending', 'sending', 'pending-virus-check',
'delivered', 'sent', 'returned-letter', 'delivered', 'sent', 'returned-letter',
'failed', 'temporary-failure', 'permanent-failure', 'technical-failure', 'failed', 'temporary-failure', 'permanent-failure', 'technical-failure',
'virus-scan-failed', 'virus-scan-failed', 'validation-failed'
] ]
), ),
( (
@@ -66,7 +66,10 @@ from tests.conftest import (
), ),
( (
'failed', 'failed',
['failed', 'temporary-failure', 'permanent-failure', 'technical-failure', 'virus-scan-failed'] [
'failed', 'temporary-failure', 'permanent-failure', 'technical-failure',
'virus-scan-failed', 'validation-failed'
]
) )
] ]
) )

8
tests/app/main/views/test_jobs.py
View File

@@ -157,7 +157,7 @@ def test_jobs_page_doesnt_show_scheduled_on_page_2(
'created', 'pending', 'sending', 'pending-virus-check', 'created', 'pending', 'sending', 'pending-virus-check',
'delivered', 'sent', 'returned-letter', 'delivered', 'sent', 'returned-letter',
'failed', 'temporary-failure', 'permanent-failure', 'technical-failure', 'failed', 'temporary-failure', 'permanent-failure', 'technical-failure',
'virus-scan-failed', 'virus-scan-failed', 'validation-failed'
] ]
), ),
( (
@@ -170,7 +170,10 @@ def test_jobs_page_doesnt_show_scheduled_on_page_2(
), ),
( (
'failed', 'failed',
['failed', 'temporary-failure', 'permanent-failure', 'technical-failure', 'virus-scan-failed'] [
'failed', 'temporary-failure', 'permanent-failure', 'technical-failure', 'virus-scan-failed',
'validation-failed'
]
) )
] ]
) )
@@ -340,6 +343,7 @@ def test_should_show_letter_job(
'permanent-failure', 'permanent-failure',
'technical-failure', 'technical-failure',
'virus-scan-failed', 'virus-scan-failed',
'validation-failed'
], ],
) )