darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-09-08 08:28:15 -04:00
Code Issues Packages Projects Releases Wiki Activity

Fixed tests

Browse Source
This commit is contained in:
Adam Shimali
2016-01-22 19:32:08 +00:00
parent f8fc8e951a
commit ba0d0d49e1
2 changed files with 10 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
app/main/views/sign_in.py
View File

@@ -2,7 +2,8 @@ from flask import (
render_template, render_template,
redirect, redirect,
url_for, url_for,
session session,
abort
) )

20
tests/app/main/views/test_sign_in.py
View File

@@ -51,7 +51,6 @@ def test_process_sign_in_return_2fa_template(app_,
assert response.location == 'http://localhost/two-factor' assert response.location == 'http://localhost/two-factor'
@pytest.mark.skip(True, reason='User failed logins not implemented yet')
def test_should_return_locked_out_true_when_user_is_locked(app_, def test_should_return_locked_out_true_when_user_is_locked(app_,
db_, db_,
db_session, db_session,
@@ -80,7 +79,6 @@ def test_should_return_locked_out_true_when_user_is_locked(app_,
assert 'Username or password is incorrect' in response.get_data(as_text=True) assert 'Username or password is incorrect' in response.get_data(as_text=True)
@pytest.mark.skip(True, reason='User failed logins not implemented yet')
def test_should_return_active_user_is_false_if_user_is_inactive(app_, def test_should_return_active_user_is_false_if_user_is_inactive(app_,
db_, db_,
db_session, db_session,
@@ -96,7 +94,9 @@ def test_should_return_active_user_is_false_if_user_is_inactive(app_,
assert 'Username or password is incorrect' in response.get_data(as_text=True) assert 'Username or password is incorrect' in response.get_data(as_text=True)
def test_should_return_200_when_user_does_not_exist(app_, db_, db_session, def test_should_return_200_when_user_does_not_exist(app_,
db_,
db_session,
mock_user_dao_get_user, mock_user_dao_get_user,
mock_user_dao_get_by_email): mock_user_dao_get_by_email):
with app_.test_request_context(): with app_.test_request_context():
@@ -108,15 +108,11 @@ def test_should_return_200_when_user_does_not_exist(app_, db_, db_session,
assert 'Username or password is incorrect' in response.get_data(as_text=True) assert 'Username or password is incorrect' in response.get_data(as_text=True)
def test_should_return_200_when_user_is_not_active(app_, db_, db_session): def test_should_return_200_when_user_is_not_active(app_,
user = User(email_address='PendingUser@example.gov.uk', db_,
password='val1dPassw0rd!', db_session,
mobile_number='+441234123123', mock_user_dao_get_user,
name='pending user', mock_user_dao_get_by_email):
created_at=datetime.now(),
role_id=1,
state='pending')
users_dao.insert_user(user)
with app_.test_request_context(): with app_.test_request_context():
response = app_.test_client().post( response = app_.test_client().post(
url_for('main.sign_in'), data={ url_for('main.sign_in'), data={