darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2025-12-13 08:34:33 -05:00
Code Issues Packages Projects Releases Wiki Activity

try reverting hardcoding

Browse Source
This commit is contained in:
Kenneth Kehl
2024-10-09 10:06:56 -07:00
parent 1cc760c153
commit b7b23ba6c8
2 changed files with 6 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
app/s3_client/__init__.py
View File

@@ -30,7 +30,9 @@ def get_s3_object(
region_name=region, region_name=region,
) )
s3 = session.resource( s3 = session.resource(
"s3", endpoint_url="https://s3-fips.us-gov-west-1.amazonaws.com" # "s3", endpoint_url="https://s3-fips.us-gov-west-1.amazonaws.com"
"s3",
config=AWS_CLIENT_CONFIG,
) )
obj = s3.Object(bucket_name, filename) obj = s3.Object(bucket_name, filename)
# This 'proves' that use of moto in the relevant tests in test_send.py # This 'proves' that use of moto in the relevant tests in test_send.py

4
notifications_utils/s3.py
View File

@@ -38,7 +38,9 @@ def s3upload(
region_name=region, region_name=region,
) )
_s3 = session.resource( _s3 = session.resource(
"s3", endpoint_url="https://s3-fips.us-gov-west-1.amazonaws.com" # "s3", endpoint_url="https://s3-fips.us-gov-west-1.amazonaws.com"
"s3",
config=AWS_CLIENT_CONFIG,
) )
# This 'proves' that use of moto in the relevant tests in test_send.py # This 'proves' that use of moto in the relevant tests in test_send.py
# mocks everything related to S3. What you will see in the logs is: # mocks everything related to S3. What you will see in the logs is: