darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-08-24 00:07:02 -04:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #3241 from alphagov/fix-logo-svg-fallback-image

Browse Source 
Send asset path to Header component
This commit is contained in:
Tom Byers
2020-01-06 11:56:17 +00:00
committed by GitHub
parent d22bf29529 6726ad31b9
commit b7af288be2
2 changed files with 11 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
app/templates/admin_template.html
View File

@@ -125,7 +125,8 @@
"homepageUrl": url_for('main.show_accounts_or_dashboard'), "homepageUrl": url_for('main.show_accounts_or_dashboard'),
"productName": "Notify", "productName": "Notify",
"navigation": navigation, "navigation": navigation,
"navigationClasses": "govuk-header__navigation--end" "navigationClasses": "govuk-header__navigation--end",
"assetsPath": asset_path + "images"
}) }} }) }}
{% endblock %} {% endblock %}

9
tests/app/main/views/test_index.py
View File

@@ -177,6 +177,15 @@ def test_css_is_served_from_correct_path(client_request):
][index]) ][index])
def test_resources_that_use_asset_path_variable_have_correct_path(client_request):
page = client_request.get('main.documentation') # easy static page
logo_svg_fallback = page.select_one('.govuk-header__logotype-crown-fallback-image')
assert logo_svg_fallback['src'].startswith('https://static.example.com/images/govuk-logotype-crown.png')
@pytest.mark.parametrize('extra_args, email_branding_retrieved', ( @pytest.mark.parametrize('extra_args, email_branding_retrieved', (
( (
{}, {},