Add a platform admin page to submit returned letter references

A platform admin form accepts a list of references (one per line)
received from DVLA and sends them to the API to update notification
statuses.

References we get from DVLA start with `NOTIFY00\d`, which isn't
part of the reference we store in the database, so we remove them
before sending the data to the API.

The new `returned-letter` status should be treated as `delivered`
for now until we decide a way to display returned letters to users.
This commit is contained in:
Alexey Bezhan
2018-09-06 16:34:23 +01:00
parent afe6d04d96
commit b75681dfbc
11 changed files with 124 additions and 8 deletions

View File

@@ -1,16 +1,19 @@
import itertools
import re
from datetime import datetime
from flask import abort, render_template, request, url_for
from flask import abort, flash, redirect, render_template, request, url_for
from flask_login import login_required
from notifications_python_client.errors import HTTPError
from app import (
complaint_api_client,
letter_jobs_client,
platform_stats_api_client,
service_api_client,
)
from app.main import main
from app.main.forms import DateFilterForm
from app.main.forms import DateFilterForm, ReturnedLettersForm
from app.statistics_utils import (
get_formatted_percentage,
get_formatted_percentage_two_dp,
@@ -202,6 +205,41 @@ def platform_admin_list_complaints():
)
@main.route("/platform-admin/returned-letters", methods=["GET", "POST"])
@login_required
@user_is_platform_admin
def platform_admin_returned_letters():
form = ReturnedLettersForm()
if form.validate_on_submit():
references = [
re.sub('NOTIFY00[0-9]', '', r.strip())
for r in form.references.data.split('\n')
if r.strip()
]
try:
letter_jobs_client.submit_returned_letters(references)
except HTTPError as error:
if error.status_code == 400:
error_references = [
re.match('references (.*) does not match', e['message']).group(1)
for e in error.message
]
form.references.errors.append("Invalid references: {}".format(', '.join(error_references)))
else:
raise error
else:
flash('Submitted {} letter references'.format(len(references)), 'default')
return redirect(
url_for('.platform_admin_returned_letters')
)
return render_template(
'views/platform-admin/returned-letters.html',
form=form,
)
def sum_service_usage(service):
total = 0
for notification_type in service['statistics'].keys():